Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check not deterministic chores (one using Random) #13

Closed
zuev93 opened this issue Feb 22, 2023 · 1 comment
Closed

Check not deterministic chores (one using Random) #13

zuev93 opened this issue Feb 22, 2023 · 1 comment
Assignees
@zuev93
Labels
enhancement New feature or request
Milestone
Dupes synchroniza...

Comments

@zuev93
Copy link
Member

zuev93 commented Feb 22, 2023 •
edited
Loading

Example of such chores:
IdleChore, MoveToSafetyChore, etc...
@zuev93 zuev93 added this to the Dupes are synced milestone Feb 22, 2023
@zuev93 zuev93 changed the title [Placeholder] Check not deterministic chores (one using Random) Check not deterministic chores (one using Random) Feb 22, 2023
@Ceron257
Copy link

Here are chores that use Unity.Random:

  • AggressiveChore
    • Used to flip a coin to decide whether a stressed out dupe destroys walls or buildings
  • BansheeChore
    • determines the maximum pathfinding cost of
      • where to wander in the wandering state
      • where to go when no other dupe to wail at is found
  • FoodFightChore used to determine
    • what other dupe to attack
    • whether to flee or cringe when being hit
  • IdleChore
    • Used to determine the timespan after which the state transitions from onfloor to idleMove or from onladder to idleMove
  • MingleChore
    • determines the time the dupe is in the onfloor state before the chore succeeds

@zuev93 zuev93 added the enhancement New feature or request label Jun 28, 2023
@zuev93 zuev93 self-assigned this Dec 7, 2023
zuev93 added a commit that referenced this issue Dec 7, 2023
@zuev93
#13 Turn on creation sync for dynamic chores.
40189af 
This PR is a part of enabling sync of dynamic chores.
@zuev93 zuev93 mentioned this issue Dec 7, 2023
Closed
zuev93 added a commit that referenced this issue Dec 9, 2023
@zuev93
#13 Generalize ChoreList (will be extended in following PRs). Disable…
ea2b8a8 
… creation chore sync for one using global providers. Improve Unit tests.
zuev93 added a commit that referenced this issue Dec 9, 2023
@zuev93
#13 Generalize ChoreList (will be extended in following PRs). Disable…
d364eca 
… creation chore sync for one using global providers. Improve Unit tests.
zuev93 added a commit that referenced this issue Dec 9, 2023
@zuev93
#13 Sync move chore creation.
f3e5b21 
It has lambda as one of arguments. However this lambda might be evaluated and sent to clients as result instead.
zuev93 added a commit that referenced this issue Dec 10, 2023
@zuev93
#13 Generalize ChoreList (will be extended in following PRs). Disable…
2b9b3e0 
… creation chore sync for one using global providers. Improve Unit tests.
zuev93 added a commit that referenced this issue Dec 10, 2023
@zuev93
#13 Sync move chore creation.
350283b 
It has lambda as one of arguments. However this lambda might be evaluated and sent to clients as result instead.
zuev93 added a commit that referenced this issue Dec 10, 2023
@zuev93
#13 Generalize ChoreList (will be extended in following PRs). Disable…
9a70566 
… creation chore sync for one using global providers. Improve Unit tests.
zuev93 added a commit that referenced this issue Dec 10, 2023
@zuev93
#13 Sync move chore creation.
dade16d 
It has lambda as one of arguments. However this lambda might be evaluated and sent to clients as result instead.
zuev93 added a commit that referenced this issue Dec 10, 2023
@zuev93
#13 Sync move chore creation. (#309)
d0d8cf8 
It has lambda as one of arguments. However this lambda might be evaluated and sent to clients as result instead.
zuev93 added a commit that referenced this issue Dec 12, 2023
@zuev93
#13 Add feature to refer to chore by MultiplayerId. Ids are synced on…
07c72fa 
…ly for chores whose creation are synced.
zuev93 added a commit that referenced this issue Dec 12, 2023
@zuev93
#13 Introduce ChoreStateEvents.cs
7e0dcb6 
The event is part of chore stat sync. This sync will be used for dynamic chores to properly sync their argument changes upon state transition. It might be not enough to cover all cases of parameter changes but this will cover some of cases for sure.
The event already enabled for some chores (3 of them) where this approach will work for sure.
zuev93 added a commit that referenced this issue Dec 13, 2023
@zuev93
#13 Enable chore creation sync for all chores. Added setting for futu…
d78b0a9 
…re providers sync.
zuev93 added a commit that referenced this issue Dec 16, 2023
@zuev93
#13 Add feature to refer to chore by MultiplayerId. Ids are synced on…
7e465b0 
…ly for chores whose creation are synced.
zuev93 added a commit that referenced this issue Dec 16, 2023
@zuev93
#13 Introduce ChoreStateEvents.cs (#311)
9c34fbc 
#13 Introduce ChoreStateEvents.cs

The event is part of chore stat sync. This sync will be used for dynamic chores to properly sync their argument changes upon state transition. It might be not enough to cover all cases of parameter changes but this will cover some of cases for sure.
The event already enabled for some chores (3 of them) where this approach will work for sure.
zuev93 added a commit that referenced this issue Dec 16, 2023
@zuev93
#13 Enable chore creation sync for all chores. Added setting for futu…
e7c7c8d 
…re providers sync. (#312)

#13 Enable chore creation sync for all chores. Added setting for future providers sync.
zuev93 added a commit that referenced this issue Dec 21, 2023
@zuev93
#13 Create TransitChoreToState.cs command.
447dd77 
Actual state transition logic will be implemented separate in a follow up PR.
zuev93 added a commit that referenced this issue Dec 21, 2023
@zuev93
#13 Create TransitChoreToState.cs command.
e60b058 
Actual state transition logic will be implemented separate in a follow up PR.
zuev93 added a commit that referenced this issue Dec 21, 2023
@zuev93
#13 Create TransitChoreToState.cs command.
531f62a 
Actual state transition logic will be implemented separate in a follow up PR.
zuev93 added a commit that referenced this issue Dec 21, 2023
@zuev93
#13 Create client patch to disable chore transition.
b812433 
StatesManager will be implemented in a follow up PR.
zuev93 added a commit that referenced this issue Dec 22, 2023
@zuev93
#13 Create TransitChoreToState.cs command.
a70aa77 
Actual state transition logic will be implemented separate in a follow up PR.
zuev93 added a commit that referenced this issue Dec 22, 2023
@zuev93
#13 Create client patch to disable chore transition. (#315)
8f15258 
#13 Create client patch to disable chore transition.

StatesManager will be implemented in a follow up PR.
zuev93 added a commit that referenced this issue Jan 21, 2024
@zuev93
#13 Fully implement state syncs for Update and EventHandler transitions.
f66ef9c 
Added SetStateArguments.cs command used by both transitions.
Disable event handlers for Event transitions.
zuev93 added a commit that referenced this issue Jan 21, 2024
@zuev93
#13 Fully implement state syncs for Update and EventHandler transitions.
cbefc83 
Added SetStateArguments.cs command used by both transitions.
Disable event handlers for Event transitions.
zuev93 added a commit that referenced this issue Jan 25, 2024
@zuev93
#13 Transit chore to wait state upon enter events specified in ChoreL…
10050cb 
…ist config.
zuev93 added a commit that referenced this issue Jan 26, 2024
@zuev93
#13 Transit chore to wait state upon enter events specified in ChoreL…
91ecdbc 
…ist config.
polycone pushed a commit that referenced this issue Jan 26, 2024
@zuev93
#13 Transit chore to wait state upon enter events specified in ChoreL…
998b67b 
…ist config. (#324)
zuev93 added a commit that referenced this issue Jan 27, 2024
@zuev93
#13 Send and execute command upon state enter transition.
9ee6ad0 
In order to avoid cycle loops (enter -> wait -> command -> enter -> wait -> ....) introduced new state `ContinuationState` which is a copy of original enter state. Now the flow looks like: enter -> wait -> command -> continuation
zuev93 added a commit that referenced this issue Jan 27, 2024
@zuev93
#13 Send and execute command upon state enter transition.
ed52f12 
In order to avoid cycle loops (enter -> wait -> command -> enter -> wait -> ....) introduced new state `ContinuationState` which is a copy of original enter state. Now the flow looks like: enter -> wait -> command -> continuation
polycone pushed a commit that referenced this issue Jan 27, 2024
@zuev93
#13 Send and execute command upon state enter transition. (#325)
2b68a05 
In order to avoid cycle loops (enter -> wait -> command -> enter -> wait -> ....) introduced new state `ContinuationState` which is a copy of original enter state. Now the flow looks like: enter -> wait -> command -> continuation
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Specify Chore configs for chores using sensors.
aa2e49b 
Syncing sensors themself won't guarantee state machine consistencies. So sync transitions results from cell sensor (Exit, Move).

Introduced new `transition` transition type. Basically it is similar to OnExit but will prevent undesired chore transition upon default conditions.
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Add new event for Transition enum value.
2dbfbfb
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Remove client transition handlers for synced chores.
17ece59 
Also merge Patches tuning state machine state transitions in one.
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Bind TransitChoreToState command upon OnStateTransition event.
5a67201
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Specify Chore configs for chores using sensors.
317fc50 
Syncing sensors themself won't guarantee state machine consistencies. So sync transitions results from cell sensor (Exit, Move).

Introduced new `transition` transition type. Basically it is similar to OnExit but will prevent undesired chore transition upon default conditions.
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Add new event for Transition enum value.
cfc4a5c
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Remove client transition handlers for synced chores.
1980654 
Also merge Patches tuning state machine state transitions in one.
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Remove client transition handlers for synced chores.
5769249 
Also merge Patches tuning state machine state transitions in one.
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Bind TransitChoreToState command upon OnStateTransition event.
777ff81
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Bind TransitChoreToState command upon OnStateTransition event.
8a96767
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Adjust state machines for moveTo syncs.
dd28ff7 
Removes EventTransition handlers.
Removes Enter handlers.
Removes update handlers.
zuev93 added a commit that referenced this issue Jan 28, 2024
@zuev93
#13 Adjust state machines for moveTo syncs.
fc170e9 
Removes EventTransition handlers.
Removes Enter handlers.
Removes update handlers.
zuev93 added a commit that referenced this issue Jan 29, 2024
@zuev93
#13 Implement move sync related events.
2f25119 
Move start and move update is quite different in comparision to regular state enter / update, because they does not change state machine they do manipulate with Navigator instead.
zuev93 added a commit that referenced this issue Jan 29, 2024
@zuev93
#13 Implement move sync related events.
7748c81 
Move start and move update is quite different in comparision to regular state enter / update, because they does not change state machine they do manipulate with Navigator instead.
zuev93 added a commit that referenced this issue Jan 29, 2024
@zuev93
#13 Implement StartMove and UpdateMove commands.
6639224 
Also connect all move related events to corresponding commands.
zuev93 added a commit that referenced this issue Jan 29, 2024
@zuev93
#13 Split TransitChoreToState event to 2: AllowStateTransition and Tr…
3b19676 
…ansitToState.cs

Old TransitChoreToState was based on assumption that stateMachine has WaitHostState, however it is not the case for move syncs and transition syncs. For those there is no waitHostState and therefore no waiting.
polycone pushed a commit that referenced this issue Jan 30, 2024
@zuev93
#13 Implement move sync related events. (#331)
37de65e 
Move start and move update is quite different in comparision to regular state enter / update, because they does not change state machine they do manipulate with Navigator instead.
polycone pushed a commit that referenced this issue Jan 30, 2024
@zuev93 @polycone
#13 Split TransitChoreToState event to 2: AllowStateTransition and Tr…
109cc8d 
…ansitToState.cs

Old TransitChoreToState was based on assumption that stateMachine has WaitHostState, however it is not the case for move syncs and transition syncs. For those there is no waitHostState and therefore no waiting.
polycone pushed a commit that referenced this issue Jan 30, 2024
@zuev93 @polycone
#13 Implement StartMove and UpdateMove commands.
4adf2ea 
Also connect all move related events to corresponding commands.
zuev93 added a commit that referenced this issue Jan 31, 2024
@zuev93
#13 Fix npe during state syncs.
1681982 
Problem was undiscovered due to faulty tests which we successfully passing. Which has been resulted due to using exposed libraries while in game runtime libraries are not exposed.

Fixed by copying original libraries to test output directory. As result 69 tests has failed.

Applied fixes for those tests.
zuev93 added a commit that referenced this issue Jan 31, 2024
@zuev93
#13 Fix npe during state syncs.
3c3e03f 
Problem was undiscovered due to faulty tests which we successfully passing. Which has been resulted due to using exposed libraries while in game runtime libraries are not exposed.

Fixed by copying original libraries to test output directory. As result 69 tests has failed.

Applied fixes for those tests.
@zuev93 zuev93 closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zuev93 zuev93

Labels
enhancement New feature or request
Projects
None yet
Milestone
Dupes synchronization
Development

No branches or pull requests
2 participants
@zuev93 @Ceron257