Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the count function, that got lost during the 6.0 upgrade #933

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

0x6368
Copy link

@0x6368 0x6368 commented Apr 29, 2020

This is the related issue: #934

@codecov-io
Copy link

codecov-io commented Apr 29, 2020

Codecov Report

Merging #933 into master will decrease coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #933      +/-   ##
============================================
- Coverage     83.13%   82.71%   -0.43%     
- Complexity      414      417       +3     
============================================
  Files            39       39              
  Lines          1364     1371       +7     
============================================
  Hits           1134     1134              
- Misses          230      237       +7     
Impacted Files Coverage Δ Complexity Δ
Service/IndexService.php 62.50% <0.00%> (-2.10%) 67.00 <3.00> (+3.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe3801c...2a958df. Read the comment docs.

@jdreesen
Copy link

jdreesen commented Jul 1, 2020

Maybe this should target the 6.2 branch as it's missing in version 6, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants