Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FLIP-0200: Application of BIP 44 in Flow Wallets #200

Merged
merged 16 commits into from
Jul 11, 2022
Merged

FLIP-0200: Application of BIP 44 in Flow Wallets #200

merged 16 commits into from
Jul 11, 2022

Conversation

psiemens
Copy link
Contributor

@psiemens psiemens commented Nov 26, 2020 •
edited
Loading

This PR proposes FLIP 200: Application of BIP 44 in Flow Wallets.

@vercel
Copy link

vercel bot commented Nov 26, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/onflow/flow-docs/3WeMJejQK7YDYkdUYg1xX7i9sEWi
✅ Preview: https://flow-docs-git-hd-accounts-onflow.vercel.app

@psiemens psiemens changed the title FLIP: Application of BIP 44 in Flow Wallets FLIP 200: Application of BIP 44 in Flow Wallets Nov 26, 2020
@psiemens psiemens added the FLIP Flow Improvement Proposal label Nov 26, 2020
@psiemens psiemens requested a review from a team November 30, 2020 00:05
@psiemens psiemens changed the title FLIP 200: Application of BIP 44 in Flow Wallets FLIP-0200: Application of BIP 44 in Flow Wallets Nov 30, 2020
Kay-Zee
Kay-Zee reviewed Nov 30, 2020
View reviewed changes
flips/20201125-bip-44-multi-account.md Outdated Show resolved Hide resolved
flips/20201125-bip-44-multi-account.md Outdated Show resolved Hide resolved
flips/20201125-bip-44-multi-account.md Outdated Show resolved Hide resolved
@psiemens
Update flips/20201125-bip-44-multi-account.md
fadac6f 
Co-authored-by: Rob Myers <rob@robmyers.org>
@psiemens psiemens mentioned this pull request Mar 12, 2021
Open
@JeffreyDoyle
Updates FLIP 200 with new proposal updates (#727)
6444dbd 
* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates

* Updates FLIP 200 with new proposal updates
@psiemens psiemens mentioned this pull request Jan 3, 2022
Merged
@tarakby
Copy link
Contributor

tarakby commented Mar 8, 2022 •
edited
Loading

Just genuinely interested, I suppose the 5 and 2 (for key account gap respectively) should have some recommending purpose? Since it's supposed to be flexible, what is the reason for defining these?

@PeterBenc Considering 5 and 2, the number of key queries required to reach a gap is 2 * 2 * 5 = 20 (curves * key gap * account gap). This matches the number of queries recommended by BIP 44 [https://github.com/bitcoin/bips/blob/master/bip-0044.mediawiki#address-gap-limit].
This is only an estimation as it is not known if a query to the Flow key registry is slower or faster than an on-chain query. The complexity (20) is equivalent, but numbers can be further adjusted by the wallet implementation.

@pgebheim pgebheim requested a review from JeffreyDoyle July 11, 2022 17:21
pgebheim
pgebheim approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@pgebheim pgebheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal has been well-argued and has full implementations.

Approving for merge.

@pgebheim pgebheim merged commit 6843221 into master Jul 11, 2022
@peterargue peterargue deleted the hd-accounts branch January 17, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterBenc PeterBenc PeterBenc left review comments

@Kay-Zee Kay-Zee Kay-Zee left review comments

@bluesign bluesign bluesign left review comments

@rheaplex rheaplex rheaplex left review comments

@pgebheim pgebheim pgebheim approved these changes

@JeffreyDoyle JeffreyDoyle Awaiting requested review from JeffreyDoyle

Assignees

@psiemens psiemens

Labels
FLIP Flow Improvement Proposal S-Governance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@psiemens @tarakby @rheaplex @pgebheim @bluesign @Kay-Zee @JeffreyDoyle @PeterBenc