Add streaming endpoints to executiondata api #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterargue
force-pushed
the
petera/add-streaming-exec-data-proto
branch
from
10cdee2
to
4ecca7d
Compare
peterargue
force-pushed
the
petera/add-streaming-exec-data-proto
branch
from
aa6c2e8
to
15818fa
Compare
SaveTheRbtz
reviewed
Mar 31, 2023
| @@ -6,6 +6,9 @@ option go_package = "github.com/onflow/flow/protobuf/go/flow/access"; | |||
| option java_package = "org.onflow.protobuf.access"; | |||
|
|
|||
| import "flow/entities/block_execution_data.proto"; | |||
| import "flow/entities/block_header.proto"; | |||
| @@ -25,4 +34,34 @@ message GetExecutionDataByBlockIDRequest { | |||
|
|
|||
| message GetExecutionDataByBlockIDResponse { | |||
| entities.BlockExecutionData block_execution_data = 1; | |||
| } | |||
There was a problem hiding this comment.
This file would need way more comments since it would likely be documentation entry point.
A good example of the documentation is google public apis: https://github.com/googleapis/googleapis/blob/master/google/spanner/v1/spanner.proto
Comment on lines
40
to
41
| bytes start_block_id = 1; | ||
| uint64 start_block_height = 2; |
There was a problem hiding this comment.
You may want to describe precedence of arguments and the behaviour when both of them are zero
Comment on lines
63
to
66
| message EventFilter { | ||
| repeated string event_type = 1; | ||
| repeated string address = 2; | ||
| repeated string contract = 3; |
There was a problem hiding this comment.
For people with a lack of context you may give a couple of examples of filters to highlight that they are OR'ed.
koko1123
approved these changes
Apr 6, 2023
SaveTheRbtz
approved these changes
Apr 6, 2023
bors bot
added a commit
to onflow/flow-go
that referenced
this pull request
Apr 10, 2023
3723: [Access] Add streaming API for BlockExecutionData r=peterargue a=peterargue Implement streaming gRPC APIs for `BlockExecutionData` and events. Protobuf: onflow/flow#1275 FLIP: onflow/flips#73 Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
peterargue
added a commit
to onflow/flow-go
that referenced
this pull request
Apr 11, 2023
3723: [Access] Add streaming API for BlockExecutionData r=peterargue a=peterargue Implement streaming gRPC APIs for `BlockExecutionData` and events. Protobuf: onflow/flow#1275 FLIP: onflow/flips#73 Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
peterargue
added a commit
to peterargue/flow-go
that referenced
this pull request
Apr 13, 2023
3723: [Access] Add streaming API for BlockExecutionData r=peterargue a=peterargue Implement streaming gRPC APIs for `BlockExecutionData` and events. Protobuf: onflow/flow#1275 FLIP: onflow/flips#73 Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
peterargue
added a commit
to onflow/flow-go
that referenced
this pull request
May 18, 2023
3723: [Access] Add streaming API for BlockExecutionData r=peterargue a=peterargue Implement streaming gRPC APIs for `BlockExecutionData` and events. Protobuf: onflow/flow#1275 FLIP: onflow/flips#73 Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
peterargue
added a commit
to onflow/flow-go
that referenced
this pull request
May 19, 2023
3723: [Access] Add streaming API for BlockExecutionData r=peterargue a=peterargue Implement streaming gRPC APIs for `BlockExecutionData` and events. Protobuf: onflow/flow#1275 FLIP: onflow/flips#73 Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #???
Description
For contributor use:
masterbranchFiles changedin the Github PR explorer