Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix User Auth and Session #322

Merged
merged 20 commits into from
Aug 29, 2023
Merged

Fix User Auth and Session #322

merged 20 commits into from
Aug 29, 2023

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Aug 29, 2023 •
edited
Loading

Closes: #271

Description

  • Refactored user authentication getting/ creating users
  • Added saving sessions upon retrieval
  • Increased default project limit to 50

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@DylanTinianov DylanTinianov self-assigned this Aug 29, 2023
@DylanTinianov DylanTinianov changed the title Fix project loading bug Refactor User Authentication Aug 29, 2023
@DylanTinianov DylanTinianov marked this pull request as ready for review August 29, 2023 15:58
@DylanTinianov DylanTinianov changed the title Refactor User Authentication Fix User Auth and Project Loading Aug 29, 2023
@DylanTinianov DylanTinianov changed the title Fix User Auth and Project Loading Fix User Auth and Session Aug 29, 2023
bthaile
bthaile approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DylanTinianov DylanTinianov merged commit 06bde90 into v2 Aug 29, 2023
@DylanTinianov DylanTinianov deleted the bugfix/project-limit-loading branch August 29, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthaile bthaile bthaile approved these changes

@turbolent turbolent Awaiting requested review from turbolent

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@devbugging devbugging Awaiting requested review from devbugging

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed loading of more than 10 projects
2 participants
@DylanTinianov @bthaile