Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create stale project scanner #140

Merged
merged 6 commits into from
Dec 1, 2022
Merged

Create stale project scanner #140

merged 6 commits into from
Dec 1, 2022

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Nov 30, 2022 •
edited
Loading

Closes: #139

Description

Added functionality for finding and deleting stale projects:

  • Added AccessedAt field to the project model in order to determine the last time a project was accessed
  • Added storage functions for finding and deleting stale projects
  • Added testing to ensure stale projects can be found and correctly deleted along with corresponding file, executions, and deployments

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@DylanTinianov DylanTinianov self-assigned this Nov 30, 2022
@DylanTinianov DylanTinianov added the improvement Technical work without new features label Nov 30, 2022
@DylanTinianov DylanTinianov changed the title Create stale project scanner Enable stale project scanning Nov 30, 2022
@DylanTinianov DylanTinianov changed the title Enable stale project scanning Create stale project scanner Nov 30, 2022
@DylanTinianov DylanTinianov marked this pull request as ready for review December 1, 2022 18:05
@DylanTinianov DylanTinianov requested a review from bthaile December 1, 2022 18:05
bthaile
bthaile approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@bthaile bthaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I don't see any issues

@DylanTinianov DylanTinianov merged commit 9355489 into v2 Dec 1, 2022
@DylanTinianov DylanTinianov deleted the improvement/accessed-time-stale-projects branch December 1, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthaile bthaile bthaile approved these changes

@psiemens psiemens Awaiting requested review from psiemens

@turbolent turbolent Awaiting requested review from turbolent

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@devbugging devbugging Awaiting requested review from devbugging

Assignees

@DylanTinianov DylanTinianov

Labels
improvement Technical work without new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanTinianov @bthaile