Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate environment to new span api #2856

Merged
merged 1 commit into from
Jul 26, 2022
Merged

migrate environment to new span api #2856

merged 1 commit into from
Jul 26, 2022

Conversation

pattyshack
Copy link
Contributor

No description provided.

Tonix517
Tonix517 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@Tonix517 Tonix517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@github-actions
Copy link
Contributor

FVM Benchstat comparison

This branch with compared with the base branch onflow:master commit 507af3e

The command (for i in {1..N}; do go test ./fvm --bench . --tags relic -shuffle=on --benchmem --run ^$; done) was used.

Bench tests were run a total of 10 times on each branch.

Collapsed results for better readability

old.txtnew.txt
time/opdelta
RuntimeNFTBatchTransfer-2156ms ± 6%154ms ± 8%~(p=0.278 n=10+9)
RuntimeTransaction/reference_tx-238.9ms ± 3%40.3ms ±13%~(p=0.460 n=8+10)
RuntimeTransaction/convert_int_to_string-241.4ms ±10%40.6ms ± 4%~(p=0.387 n=9+9)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-242.8ms ± 7%42.7ms ± 4%~(p=0.963 n=9+8)
RuntimeTransaction/get_signer_address-239.9ms ± 4%42.5ms ±20%~(p=0.315 n=9+10)
RuntimeTransaction/get_public_account-243.4ms ± 3%44.1ms ±14%~(p=1.000 n=9+9)
RuntimeTransaction/get_account_and_get_balance-2725ms ±12%707ms ± 3%~(p=0.661 n=10+9)
RuntimeTransaction/get_account_and_get_available_balance-2579ms ± 6%610ms ±10%~(p=0.143 n=10+10)
RuntimeTransaction/get_account_and_get_storage_used-249.6ms ± 5%49.0ms ± 5%~(p=0.370 n=8+9)
RuntimeTransaction/get_account_and_get_storage_capacity-2533ms ± 4%552ms ±11%~(p=0.050 n=9+9)
RuntimeTransaction/get_signer_vault-251.4ms ±10%48.8ms ± 5%~(p=0.211 n=10+9)
RuntimeTransaction/get_signer_receiver-263.2ms ± 2%63.1ms ± 5%~(p=0.888 n=8+9)
RuntimeTransaction/transfer_tokens-2273ms ± 3%273ms ± 1%~(p=0.743 n=9+8)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-248.4ms ± 5%48.0ms ± 3%~(p=0.720 n=10+9)
RuntimeTransaction/load_and_save_long_string_on_signers_address-299.3ms ± 3%99.3ms ± 5%~(p=0.730 n=9+9)
RuntimeTransaction/create_new_account-21.35s ± 6%1.35s ± 7%~(p=0.730 n=9+9)
RuntimeTransaction/call_empty_contract_function-242.8ms ± 3%43.5ms ± 6%~(p=0.236 n=8+9)
RuntimeTransaction/emit_event-261.6ms ± 1%64.0ms ±13%~(p=0.762 n=8+10)
RuntimeTransaction/borrow_array_from_storage-2150ms ± 5%152ms ± 3%~(p=0.661 n=10+9)
RuntimeTransaction/copy_array_from_storage-2154ms ± 3%152ms ± 2%~(p=0.436 n=9+9)
 
alloc/opdelta
RuntimeNFTBatchTransfer-227.4MB ± 0%27.5MB ± 0%+0.14%(p=0.016 n=9+8)
RuntimeTransaction/call_empty_contract_function-210.5MB ± 0%10.6MB ± 0%+0.14%(p=0.036 n=8+9)
RuntimeTransaction/get_account_and_get_storage_capacity-2142MB ± 0%143MB ± 0%+0.10%(p=0.000 n=10+8)
RuntimeTransaction/get_account_and_get_available_balance-2148MB ± 0%148MB ± 0%+0.09%(p=0.000 n=10+10)
RuntimeTransaction/create_new_account-2263MB ± 0%263MB ± 0%+0.09%(p=0.000 n=9+10)
RuntimeTransaction/get_account_and_get_balance-2197MB ± 0%197MB ± 0%+0.05%(p=0.000 n=9+9)
RuntimeTransaction/reference_tx-29.72MB ± 1%9.71MB ± 0%~(p=0.353 n=10+10)
RuntimeTransaction/convert_int_to_string-210.2MB ± 1%10.2MB ± 1%~(p=0.393 n=10+10)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-210.7MB ± 1%10.7MB ± 1%~(p=0.393 n=10+10)
RuntimeTransaction/get_signer_address-29.92MB ± 1%9.95MB ± 0%~(p=0.052 n=10+10)
RuntimeTransaction/get_public_account-211.4MB ± 1%11.4MB ± 1%~(p=0.353 n=10+10)
RuntimeTransaction/get_account_and_get_storage_used-212.6MB ± 0%12.6MB ± 0%~(p=0.971 n=10+10)
RuntimeTransaction/get_signer_vault-211.9MB ± 0%11.9MB ± 1%~(p=0.780 n=9+10)
RuntimeTransaction/get_signer_receiver-215.7MB ± 1%15.8MB ± 0%~(p=0.278 n=10+9)
RuntimeTransaction/transfer_tokens-250.7MB ± 0%50.8MB ± 0%~(p=0.971 n=10+10)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-211.4MB ± 1%11.3MB ± 0%~(p=0.095 n=10+9)
RuntimeTransaction/load_and_save_long_string_on_signers_address-225.5MB ± 0%25.5MB ± 0%~(p=0.063 n=10+10)
RuntimeTransaction/emit_event-214.9MB ± 0%14.9MB ± 1%~(p=0.356 n=9+10)
RuntimeTransaction/borrow_array_from_storage-235.9MB ± 1%36.0MB ± 0%~(p=0.143 n=10+10)
RuntimeTransaction/copy_array_from_storage-247.1MB ± 0%47.0MB ± 0%~(p=0.353 n=10+10)
 
allocs/opdelta
RuntimeTransaction/get_account_and_get_storage_used-2213k ± 0%215k ± 0%+0.84%(p=0.000 n=10+9)
RuntimeTransaction/emit_event-2218k ± 0%219k ± 0%+0.84%(p=0.000 n=10+10)
RuntimeTransaction/create_new_account-24.36M ± 0%4.39M ± 0%+0.64%(p=0.000 n=9+10)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2298k ± 0%299k ± 0%+0.62%(p=0.000 n=10+9)
RuntimeNFTBatchTransfer-2385k ± 0%387k ± 0%+0.62%(p=0.000 n=8+8)
RuntimeTransaction/get_account_and_get_available_balance-22.63M ± 0%2.65M ± 0%+0.52%(p=0.000 n=10+10)
RuntimeTransaction/reference_tx-2154k ± 0%155k ± 0%+0.51%(p=0.000 n=10+10)
RuntimeTransaction/get_account_and_get_storage_capacity-22.49M ± 0%2.50M ± 0%+0.51%(p=0.000 n=10+10)
RuntimeTransaction/get_signer_address-2160k ± 0%160k ± 0%+0.50%(p=0.000 n=10+10)
RuntimeTransaction/call_empty_contract_function-2171k ± 0%172k ± 0%+0.48%(p=0.000 n=9+10)
RuntimeTransaction/convert_int_to_string-2169k ± 0%169k ± 0%+0.46%(p=0.000 n=10+9)
RuntimeTransaction/get_account_and_get_balance-23.27M ± 0%3.28M ± 0%+0.45%(p=0.000 n=10+9)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2183k ± 0%184k ± 0%+0.43%(p=0.000 n=10+10)
RuntimeTransaction/get_public_account-2191k ± 0%192k ± 0%+0.42%(p=0.000 n=10+10)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2205k ± 0%206k ± 0%+0.40%(p=0.000 n=10+10)
RuntimeTransaction/get_signer_vault-2207k ± 0%208k ± 0%+0.40%(p=0.000 n=10+10)
RuntimeTransaction/transfer_tokens-21.06M ± 0%1.07M ± 0%+0.37%(p=0.000 n=10+10)
RuntimeTransaction/get_signer_receiver-2296k ± 0%297k ± 0%+0.28%(p=0.000 n=10+10)
RuntimeTransaction/copy_array_from_storage-2406k ± 0%406k ± 0%+0.22%(p=0.000 n=10+9)
RuntimeTransaction/borrow_array_from_storage-2449k ± 0%450k ± 0%+0.19%(p=0.000 n=9+10)
 
computationdelta
RuntimeTransaction/reference_tx-2202 ± 0%202 ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-2502 ± 0%502 ± 0%~(all equal)
RuntimeTransaction/get_signer_address-2302 ± 0%302 ± 0%~(all equal)
RuntimeTransaction/get_public_account-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_balance-21.00k ± 0%1.00k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_available_balance-22.50k ± 0%2.50k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_used-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-21.30k ± 0%1.30k ± 0%~(all equal)
RuntimeTransaction/get_signer_vault-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/get_signer_receiver-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/transfer_tokens-23.50k ± 0%3.50k ± 0%~(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/create_new_account-2202 ± 0%202 ± 0%~(all equal)
RuntimeTransaction/call_empty_contract_function-2402 ± 0%402 ± 0%~(all equal)
RuntimeTransaction/emit_event-2602 ± 0%602 ± 0%~(all equal)
RuntimeTransaction/borrow_array_from_storage-22.60k ± 0%2.60k ± 0%~(all equal)
RuntimeTransaction/copy_array_from_storage-22.60k ± 0%2.60k ± 0%~(all equal)
 
interactionsdelta
RuntimeTransaction/reference_tx-247.8k ± 0%47.8k ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string-247.8k ± 0%47.8k ± 0%~(all equal)
RuntimeTransaction/convert_int_to_string_and_concatenate_it-247.8k ± 0%47.8k ± 0%~(all equal)
RuntimeTransaction/get_signer_address-247.8k ± 0%47.8k ± 0%~(all equal)
RuntimeTransaction/get_public_account-247.8k ± 0%47.8k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_balance-216.8M ± 0%16.8M ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_available_balance-25.34M ± 0%5.34M ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_used-251.4k ± 0%51.4k ± 0%~(all equal)
RuntimeTransaction/get_account_and_get_storage_capacity-25.34M ± 0%5.34M ± 0%~(all equal)
RuntimeTransaction/get_signer_vault-249.0k ± 0%49.0k ± 0%~(all equal)
RuntimeTransaction/get_signer_receiver-249.4k ± 0%49.4k ± 0%~(all equal)
RuntimeTransaction/transfer_tokens-250.2k ± 0%50.2k ± 0%~(all equal)
RuntimeTransaction/load_and_save_empty_string_on_signers_address-251.2k ± 0%51.2k ± 0%~(all equal)
RuntimeTransaction/load_and_save_long_string_on_signers_address-256.2k ± 0%56.2k ± 0%~(all equal)
RuntimeTransaction/create_new_account-28.49M ± 0%8.49M ± 0%~(all equal)
RuntimeTransaction/call_empty_contract_function-248.0k ± 0%48.0k ± 0%~(all equal)
RuntimeTransaction/emit_event-248.0k ± 0%48.0k ± 0%~(all equal)
RuntimeTransaction/borrow_array_from_storage-254.1k ± 0%54.1k ± 0%~(all equal)
RuntimeTransaction/copy_array_from_storage-254.1k ± 0%54.1k ± 0%~(all equal)
 

@pattyshack
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Jul 25, 2022
@bors @SaveTheRbtz @pattyshack
Merge #2853 #2856
3156262 
2853: [FVM] Update cadence to support Executor pattern r=SaveTheRbtz a=SaveTheRbtz

Factored out cadence update and test fixes out of #2837 so that we can break circular dependency on #2823

Co-authored-by: Janez Podhostnik <janez.podhostnik@gmail.com>

2856: migrate environment to new span api r=pattyshack a=pattyshack



Co-authored-by: Alexey Ivanov <rbtz@dapperlabs.com>
Co-authored-by: Patrick Lee <patrick.lee@dapperlabs.com>
@bors
Copy link
Contributor

bors bot commented Jul 25, 2022

This PR was included in a batch that timed out, it will be automatically retried

@bors
Copy link
Contributor

bors bot commented Jul 26, 2022

Build succeeded:

@bors bors bot merged commit 093ec58 into master Jul 26, 2022
@bors bors bot deleted the patrick/env-span-api-change branch July 26, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tonix517 Tonix517 Tonix517 approved these changes

@SaveTheRbtz SaveTheRbtz SaveTheRbtz approved these changes

@ramtinms ramtinms Awaiting requested review from ramtinms

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pattyshack @SaveTheRbtz @Tonix517