[Admin] add log level customization command #1362
Conversation
|
Yeeeah, I would actually just crank log level to debug and that's it. |
@huitseeker I considered this too. On one hand, it looks like this should be possible: https://github.com/rs/zerolog#setting-global-log-level On the other hand, not sure if it's actually possible to do this at runtime: rs/zerolog#252 I'll look into this and investigate further. |
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
==========================================
- Coverage 55.29% 55.27% -0.02%
==========================================
Files 516 516
Lines 32181 32185 +4
==========================================
- Hits 17793 17790 -3
- Misses 12001 12007 +6
- Partials 2387 2388 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
synzhu
changed the title
| log = log.Level(zerolog.DebugLevel) | ||
| zerolog.SetGlobalLevel(lvl) |
There was a problem hiding this comment.
why using debug level as global level?
Better to use InfoLevel as default
There was a problem hiding this comment.
The way this works, is that SetGlobalLevel sets the minimum level that will be logged, regardless of what the root logger has set.
So, I set the root logger to Debug level, and use SetGlobalLevel to set the actual level we want to use. This is the only way to make the log level dynamically configurable. I cannot do things the other way around, because once the root logger's level is set, you cannot change it.
Hope this makes sense.
| @@ -242,14 +247,15 @@ func (r *CommandRunner) runAdminServer(ctx context.Context) error { | |||
| func (r *CommandRunner) runCommand(ctx context.Context, command string, data map[string]interface{}) error { | |||
| r.logger.Info().Str("command", command).Msg("received new command") | |||
There was a problem hiding this comment.
better to log the input and output of each command call.
- if it receives a command, it should log
received new command - if it has run the command, it should log
finish running the command - if it fails to run the command, it should log
failed to run the commandwith the error message.
There was a problem hiding this comment.
this will be done in a separate PR :)
|
bors merge |
Add log level admin command, to allow dynamically changing the log level without restarting a node.
Tested and it works on localnet.
To change the log level to debug, for example:
where
localhost:5873is the address of the admin server.