Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type parameter to createEmptyVault in FlowToken setup transaction #445

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Add type parameter to createEmptyVault in FlowToken setup transaction #445

merged 3 commits into from
Sep 4, 2024

Conversation

bluesign
Copy link
Contributor

@bluesign bluesign commented Sep 4, 2024

closes #444

joshuahannan
joshuahannan approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joshuahannan
Copy link
Member

Can you run make test and push your changes again?

@bluesign
Copy link
Contributor Author

bluesign commented Sep 4, 2024

@joshuahannan just did. actually I ran the tests but I forgot to add generated file.

@joshuahannan joshuahannan merged commit 43c142f into onflow:master Sep 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuahannan joshuahannan joshuahannan approved these changes

@sisyphusSmiling sisyphusSmiling sisyphusSmiling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix setup account transaction for flow token
3 participants
@bluesign @joshuahannan @sisyphusSmiling