Add docs directory #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psiemens
added
the
Documentation
psiemens
requested review from
janezpodhostnik,
Kay-Zee and
turbolent
as code owners
devbugging
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
I think docs look great. More commands should be documented in the future and the home page should have general info, maybe a command structure tree etc...
One comment is that maybe flow accounts create could have a precondition that you have to run flow init since if you just come to that page in readme not knowing other things someone might be confused why is not working but that is minor.
janezpodhostnik
approved these changes
Feb 15, 2021
docs/query-transactions.md
Outdated
|
|
||
| Indicate whether to wait for the transaction to be sealed. | ||
| If true, the CLI will block until the transaction has been sealed or | ||
| a timeout is reached. |
There was a problem hiding this comment.
It would be great to mention what the timeout is here I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
/docsdirectory that can be imported by the Flow documentation website.Check out the live build: https://docs.onflow.org/flow-cli/
For contributor use:
masterbranchFiles changedin the Github PR explorer