Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix transaction multiple function declaration #444

Merged
merged 6 commits into from
Jan 25, 2022
Merged

Conversation

devbugging
Copy link
Contributor

Closes #437

Description

This PR fixes a bug where a transaction includes multiple function declarations due to nature of SoleTransactionDeclaration.

Example of such transaction is:

pub fun dummy(_ address: Address): Void {}

transaction {
  prepare(acct: AuthAccount) {}
}

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

I'm wondering if it would make sense to change how SoleTransactionDeclaration works instead, so that his would be possible. I guess this is question for @Bastian @turbolent and definitely not in scope here.

edit: Sorry for the ping other Bastian!

@Bastian
Copy link

Bastian commented Jan 25, 2022

I guess this is question for @Bastian

I disagree 😉

@devbugging
Copy link
Contributor Author

The changes look good.

I'm wondering if it would make sense to change how SoleTransactionDeclaration works instead, so that his would be possible. I guess this is question for @Bastian and definitely not in scope here.

@janezpodhostnik you probably mean @turbolent
I assumed from the naming of the func that this is indeed how it should work but yeah maybe Bastian can share some light.

@devbugging devbugging merged commit 3d9966a into master Jan 25, 2022
@devbugging devbugging deleted the bugfix/funcs branch January 26, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK can't parse transactions with functions
3 participants