Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: state loader tests #412

Merged
merged 5 commits into from
Nov 17, 2021
Merged

Tests: state loader tests #412

merged 5 commits into from
Nov 17, 2021

Conversation

devbugging
Copy link
Contributor

Description

Add more tests for state loader.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #412 (25ab3b9) into master (f3eb6a1) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   55.24%   55.50%   +0.26%     
==========================================
  Files          36       36              
  Lines        1906     1906              
==========================================
+ Hits         1053     1058       +5     
+ Misses        718      711       -7     
- Partials      135      137       +2     
Flag Coverage Δ
unittests 55.50% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/flowkit/state.go 60.41% <0.00%> (+5.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3eb6a1...25ab3b9. Read the comment docs.

Gregor Gololicic added 3 commits November 17, 2021 15:01
Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devbugging devbugging merged commit 0a29d6e into master Nov 17, 2021
@devbugging devbugging deleted the tests/state-test branch November 17, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants