Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #396

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Update dependencies #396

merged 3 commits into from
Oct 29, 2021

Conversation

devbugging
Copy link
Contributor

@devbugging devbugging commented Oct 5, 2021

Description

Update flow dependencies to latest versions:

  • emulator v0.22.0 -> 0.23.0
  • cadence v0.18.1-0.20210621144040-64e6b6fb2337 -> v0.19.1
  • flow go v0.18.4 -> v0.21.3
  • go sdk v0.20.1-0.20210623043139-533a95abf071 -> v0.22.0
  • languageserver v0.18.3-0.20210922170423-869cc8faab9b -> v0.18.3-0.20211005105715-3c618f0fcd10 (we need to release a tagged version after)

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@devbugging devbugging changed the title Update emulator Update dependencies Oct 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #396 (422b8ac) into master (ff1f8b1) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
- Coverage   55.33%   55.24%   -0.09%     
==========================================
  Files          36       36              
  Lines        1874     1877       +3     
==========================================
  Hits         1037     1037              
- Misses        707      710       +3     
  Partials      130      130              
Flag Coverage Δ
unittests 55.24% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/flowkit/keys.go 32.60% <ø> (+0.35%) ⬆️
pkg/flowkit/transaction.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1f8b1...422b8ac. Read the comment docs.

Copy link
Contributor

@janezpodhostnik janezpodhostnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left a small comment.

pkg/flowkit/arguments_test.go Outdated Show resolved Hide resolved
@devbugging devbugging merged commit 94792f3 into master Oct 29, 2021
@devbugging devbugging deleted the improvement/update-emulator branch November 17, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants