Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't overflow on last bigger than end #392

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

devbugging
Copy link
Contributor

Description

When running locally if fewer blocks were created than the last flag specified then it overflowed the range.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

Codecov Report

Merging #392 (c8ef2ff) into master (ff1f8b1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   55.33%   55.33%           
=======================================
  Files          36       36           
  Lines        1874     1874           
=======================================
  Hits         1037     1037           
  Misses        707      707           
  Partials      130      130           
Flag Coverage Δ
unittests 55.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1f8b1...c8ef2ff. Read the comment docs.

@devbugging devbugging merged commit 3065b5e into master Oct 29, 2021
@devbugging devbugging deleted the bugfix/bound-event-range branch October 29, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants