Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Cadence v0.13.5-no-id-caching and Emulator v0.16.1 #107

Merged
merged 4 commits into from
Mar 10, 2021
Merged

Update to Cadence v0.13.5-no-id-caching and Emulator v0.16.1 #107

merged 4 commits into from
Mar 10, 2021

Conversation

turbolent
Copy link
Member

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added Improvement Technical work without new features, refactoring, improving tests Bugfix labels Mar 10, 2021
@turbolent turbolent requested a review from Kay-Zee as a code owner March 10, 2021 20:07
@turbolent turbolent self-assigned this Mar 10, 2021
psiemens
psiemens approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@psiemens psiemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the linter is failing -- it has been timing out recently.

@psiemens
Copy link
Contributor

I'm going to try to adjust the CI workflow to see if this is failing due to resource constraints.

@psiemens
Copy link
Contributor

Nice, CI is green. LGTM! 🚢

@turbolent turbolent merged commit b54d5ee into master Mar 10, 2021
@turbolent turbolent deleted the bastian/cadence-v0.13.5-no-id-caching branch March 10, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psiemens psiemens psiemens approved these changes

@janezpodhostnik janezpodhostnik janezpodhostnik approved these changes

@devbugging devbugging Awaiting requested review from devbugging

@Kay-Zee Kay-Zee Awaiting requested review from Kay-Zee Kay-Zee is a code owner

Assignees

@turbolent turbolent

Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turbolent @psiemens @janezpodhostnik