Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for onfido-php library #45

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

sofia-gomes-onfido
Copy link
Contributor

@sofia-gomes-onfido sofia-gomes-onfido commented May 21, 2024

Includes tests for the following instances:

  • applicants
  • address
  • webhooks
  • checks
  • documents
  • extraction
  • live photos
  • live videos
  • motion
  • reports (including detailed validation of schemas)
  • SDK token
  • tasks
  • workflow runs (including detailed validation of output schemas)
  • watchlist monitors

@sofia-gomes-onfido sofia-gomes-onfido force-pushed the test/add-tests branch 14 times, most recently from 2120d33 to a1e2df4 Compare May 23, 2024 10:51
@sofia-gomes-onfido sofia-gomes-onfido changed the title Test/add tests test: add tests for onfido-php library May 23, 2024
@sofia-gomes-onfido sofia-gomes-onfido marked this pull request as ready for review May 23, 2024 10:57
@sofia-gomes-onfido sofia-gomes-onfido self-assigned this May 23, 2024
Copy link
Contributor

@dvacca-onfido dvacca-onfido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm just wondering if we should squash all these commit before merging or if it makes sense keeping each of them aside.

@sofia-gomes-onfido sofia-gomes-onfido merged commit ed72f03 into master May 23, 2024
1 check passed
@sofia-gomes-onfido sofia-gomes-onfido deleted the test/add-tests branch May 23, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants