Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli.waitFor now deprecated #229

Closed
Rodsevich opened this issue Feb 16, 2024 · 3 comments
Closed

cli.waitFor now deprecated #229

Rodsevich opened this issue Feb 16, 2024 · 3 comments

Comments

@Rodsevich
Copy link

Rodsevich commented Feb 16, 2024

Describe the bug
On master branch of flutter, when using copy() (at least) the dcli package fails as follows:

Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121.
  dart:cli                                      waitFor
  package:dcli/src/util/wait_for_ex.dart 38:17  waitForEx
  package:dcli/src/functions/copy.dart 38:5     copy

To Reproduce
use a copy():

copy('file1.txt','file2.txt');

Expected behavior
The copy succeds

Logs
If applicable, add any logs to help explain your problem.

Run dcli doctor:
From the cli run dcli doctor

DCli version      3.3.5                                                  

os                linux                                                  
os version        Linux 6.5.0-17-generic #17-Ubuntu SMP PREEMPT_DYNAMIC Thu Jan 11 14:01:59 UTC 2024
path separator    /                                                      

dart version      3.4.0-52.0.dev                                         

String: Synchronous waiting using dart:cli waitFor and C API Dart_WaitForEvent is deprecated and disabled by default. This feature will be fully removed in Dart 3.4 release. You can currently still enable it by passing --enable_deprecated_wait_for to the Dart VM. See https://dartbug.com/52121. 
Stacktrace: dart:cli                                                  waitFor
package:dcli/src/util/wait_for_ex.dart 36:17              waitForEx
package:dcli/src/functions/which.dart 97:5                which
package:dcli/src/util/dcli_paths.dart 42:20               DCliPaths.pathToDCli
package:dcli/src/commands/doctor.dart 125:36              DoctorCommand._printExePaths
package:dcli/src/commands/doctor.dart 43:5                DoctorCommand.run
package:dcli/src/script/command_line_runner.dart 98:33    CommandLineRunner.process
package:dcli/src/script/entry_point.dart 44:44            EntryPoint._parseCmdLine
package:dcli/src/script/entry_point.dart 38:7             EntryPoint.process
.pub-cache/hosted/pub.dev/dcli-3.3.5/bin/dcli.dart 17:41  DCli.run
.pub-cache/hosted/pub.dev/dcli-3.3.5/bin/dcli.dart 12:16  main
dart:isolate                                              _RawReceivePort._handleMessage
package:dcli/src/util/wait_for_ex.dart 33:28              waitForEx
package:dcli/src/functions/which.dart 97:5                which
package:dcli/src/util/dcli_paths.dart 42:20               DCliPaths.pathToDCli
package:dcli/src/commands/doctor.dart 125:36              DoctorCommand._printExePaths
package:dcli/src/commands/doctor.dart 43:5                DoctorCommand.run
package:dcli/src/script/command_line_runner.dart 98:33    CommandLineRunner.process
package:dcli/src/script/entry_point.dart 44:44            EntryPoint._parseCmdLine
package:dcli/src/script/entry_point.dart 38:7             EntryPoint.process
.pub-cache/hosted/pub.dev/dcli-3.3.5/bin/dcli.dart 17:41  DCli.run
.pub-cache/hosted/pub.dev/dcli-3.3.5/bin/dcli.dart 12:16  main

Additional context
dart-lang/sdk#52121

@bsutton
Copy link
Collaborator

bsutton commented Apr 5, 2024

have a go of the dcli 4.0.1-beta.1 it should have fixes for most problems now.

@bsutton
Copy link
Collaborator

bsutton commented Apr 13, 2024

beta 4 has been released and it looks like we pretty much have these issues solved.

@bsutton
Copy link
Collaborator

bsutton commented May 14, 2024

4.0.0 has been released which resolve this issue.

@bsutton bsutton closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants