Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EE-1972: Add ruby 3.2.2 support #31

Merged
merged 1 commit into from
Dec 14, 2023
Merged

EE-1972: Add ruby 3.2.2 support #31

merged 1 commit into from
Dec 14, 2023

Conversation

vineelvineel
Copy link
Contributor

@vineelvineel vineelvineel commented Dec 12, 2023 •
edited by jira bot
Loading

EE-1972

Upgrade ruby version and also gem version

@vineelvineel vineelvineel self-assigned this Dec 12, 2023
adamstegman
adamstegman reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@adamstegman adamstegman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexadia had reported that bin/rails scrub was not working as expected—have you had a chance to test that?

lib/acts_as_scrubbable/version.rb Outdated Show resolved Hide resolved
@alexadia
Copy link
Contributor

alexadia commented Dec 14, 2023 •
edited
Loading

bin/rails --trace scrub SCRUB_CLASSES=B2bCompany is the specific command that isn't respecting the env var SCRUB_CLASSES. It tries to scrub everything.

Update: If you run it with SKIP_AFTERHOOK=true one will notice that it is actually respecting the env var, it is just that it is also scrubbing related records.

@alexadia
Copy link
Contributor

Could we also add in this PR or in another one to have CircleCI run the specs?

In the meantime, what were the results of running rspec spec on this branch?

@vineelvineel
Copy link
Contributor Author

Could we also add in this PR or in another one to have CircleCI run the specs?

In the meantime, what were the results of running rspec spec on this branch?

24 out of 24 specs fail. I didnt realize there were specs in this

@smasry
Copy link
Contributor

smasry commented Dec 14, 2023

This PR fixes the specs
#32

@vineelvineel vineelvineel force-pushed the EE-1972-support-ruby3.2.2-version branch from 0ce4932 to b0b28d0 Compare December 14, 2023 21:21
EE-1972: Revert the version back to 2.1.1
c22dd83 
EE-1972: Use 1.0 version

EE-1972: Update activerecord-nulldb-adapter version to 1.0.1

EE-1972: Add ruby 3.2.2 support
@vineelvineel vineelvineel force-pushed the EE-1972-support-ruby3.2.2-version branch from b0b28d0 to c22dd83 Compare December 14, 2023 21:22
@vineelvineel
Copy link
Contributor Author

@alexadia @adamstegman Please re-review this. Thanks

@vineelvineel vineelvineel merged commit 465f700 into main Dec 14, 2023
@vineelvineel vineelvineel deleted the EE-1972-support-ruby3.2.2-version branch December 14, 2023 21:29
@greenapples
Copy link

greenapples commented Dec 14, 2023 via email

@adamstegman
Copy link
Member

@greenapples it doesn't look like you have any contributor access to the repo, it's just public. You may need to change your watching settings for the repository so you're not notified of new issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstegman adamstegman adamstegman approved these changes

@alexadia alexadia Awaiting requested review from alexadia

Assignees

@vineelvineel vineelvineel

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vineelvineel @alexadia @smasry @greenapples @adamstegman