Support Rails 7 #24
Merged
Support Rails 7 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 6.1 deprecated `connection_config` in favor of `connection_db_config`, and Rails 7 removes it. Add tests to catch this problem.
Merged
adamstegman
commented
Aug 19, 2022
| s.add_runtime_dependency 'activerecord' , '>= 4.1', '< 8' | ||
| s.add_runtime_dependency 'railties' , '>= 4.1', '< 8' | ||
| s.add_runtime_dependency 'activesupport' , '>= 6.1', '< 8' | ||
| s.add_runtime_dependency 'activerecord' , '>= 6.1', '< 8' |
There was a problem hiding this comment.
connection_db_config was added in 6.1, so this will be a major version bump to remove this support.
looks good!
alexadia
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 6.1 deprecated
connection_configin favor ofconnection_db_config, and Rails 7 removes it. Add tests to catch this problem.