-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[L0] Remove handle Translation in MCL if loader extension used #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
level-zero
L0 adapter specific issues
command-buffer
Command Buffer feature addition/changes/specification
labels
Dec 23, 2024
fabiomestre
force-pushed
the
neil-fix
branch
from
December 23, 2024 16:52
b7be172
to
3eb9dfb
Compare
Bensuo
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just one minor comment.
fabiomestre
force-pushed
the
neil-fix
branch
2 times, most recently
from
December 23, 2024 18:02
772c46a
to
b1ae104
Compare
- Fixes the translation of handles which is not needed when the loader extension of MCL is used. This also fixes the problem during multi driver scenarios. Co-authored-by: Neil R. Spruit <neil.r.spruit@intel.com> Co-authored-by: Fabio Mestre <fabio.mestre@codeplay.com>
fabiomestre
force-pushed
the
neil-fix
branch
from
December 23, 2024 19:05
b1ae104
to
160495a
Compare
@oneapi-src/unified-runtime-level-zero-write could someone review this PR? |
nrspruit
approved these changes
Jan 6, 2025
dm-vodopyanov
pushed a commit
to intel/llvm
that referenced
this pull request
Jan 7, 2025
Batches the following bug fixes: * oneapi-src/unified-runtime#2504 * oneapi-src/unified-runtime#2517 * oneapi-src/unified-runtime#2524 --------- Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com> Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
kbenzie
added a commit
that referenced
this pull request
Jan 7, 2025
[L0] Remove handle Translation in MCL if loader extension used
kbenzie
added a commit
that referenced
this pull request
Jan 7, 2025
[L0] Remove handle Translation in MCL if loader extension used
kbenzie
added a commit
that referenced
this pull request
Jan 8, 2025
[L0] Remove handle Translation in MCL if loader extension used
kbenzie
added a commit
that referenced
this pull request
Jan 8, 2025
[L0] Remove handle Translation in MCL if loader extension used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
command-buffer
Command Buffer feature addition/changes/specification
level-zero
L0 adapter specific issues
ready to merge
Added to PR's which are ready to merge
v0.11.x
Include in the v0.11.x release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intel/llvm PR: intel/llvm#16459