Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L0] Remove handle Translation in MCL if loader extension used #2504

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

fabiomestre
Copy link
Contributor

@fabiomestre fabiomestre commented Dec 23, 2024

  • Fixes the translation of handles which is not needed when the loader extension of MCL is used. This also fixes the problem during multi driver scenarios.

intel/llvm PR: intel/llvm#16459

@github-actions github-actions bot added level-zero L0 adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Dec 23, 2024
@fabiomestre fabiomestre marked this pull request as ready for review December 23, 2024 17:15
@fabiomestre fabiomestre requested review from a team as code owners December 23, 2024 17:15
@fabiomestre fabiomestre added the v0.11.x Include in the v0.11.x release label Dec 23, 2024
Copy link
Contributor

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one minor comment.

source/adapters/level_zero/platform.hpp Show resolved Hide resolved
- Fixes the translation of handles which is not needed when the loader
  extension of MCL is used. This also fixes the problem during multi
driver scenarios.

Co-authored-by: Neil R. Spruit <neil.r.spruit@intel.com>
Co-authored-by: Fabio Mestre <fabio.mestre@codeplay.com>
@fabiomestre
Copy link
Contributor Author

@oneapi-src/unified-runtime-level-zero-write could someone review this PR?

@nrspruit nrspruit added the ready to merge Added to PR's which are ready to merge label Jan 6, 2025
@kbenzie kbenzie merged commit 45e3405 into oneapi-src:main Jan 7, 2025
73 checks passed
dm-vodopyanov pushed a commit to intel/llvm that referenced this pull request Jan 7, 2025
Batches the following bug fixes:

* oneapi-src/unified-runtime#2504
* oneapi-src/unified-runtime#2517
* oneapi-src/unified-runtime#2524

---------

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
kbenzie added a commit that referenced this pull request Jan 7, 2025
[L0] Remove handle Translation in MCL if loader extension used
kbenzie added a commit that referenced this pull request Jan 7, 2025
[L0] Remove handle Translation in MCL if loader extension used
kbenzie added a commit that referenced this pull request Jan 8, 2025
[L0] Remove handle Translation in MCL if loader extension used
kbenzie added a commit that referenced this pull request Jan 8, 2025
[L0] Remove handle Translation in MCL if loader extension used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command-buffer Command Buffer feature addition/changes/specification level-zero L0 adapter specific issues ready to merge Added to PR's which are ready to merge v0.11.x Include in the v0.11.x release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants