[DeviceSanitizer] Add a report flag to LaunchInfo #2069
Conversation
This flag is used to control error report process.
github-actions
bot
added
loader
| @@ -79,6 +79,7 @@ struct LaunchInfo { | |||
| uint32_t NumLocalArgs = 0; | |||
| LocalArgsInfo *LocalArgs = nullptr; // Ordered by ArgIndex | |||
|
|
|||
| int ReportFlag = 0; | |||
There was a problem hiding this comment.
Just a general comment: I really dislike the fact that we have an implicit ABI requirement on these structures, where they need to be kept in sync between the two repos.
Would it be possible to refactor this so that we move these structures into a separate header (in include/) that the libdevice/include/asan_libdevice.hpp uses?
There was a problem hiding this comment.
@pbalcer, can we make a common include folder in sycl runtime?
There was a problem hiding this comment.
There's already a ur-related header in sycl runtime:
https://github.com/intel/llvm/blob/sycl/sycl/include/sycl/detail/ur.hpp
is that what you mean?
Why though? I was more thinking about putting the headers in UR and then including them in SYCL.
There was a problem hiding this comment.
I thought wrong, I want to move "asan_libdevice.hpp" into sycl runtime.
I was more thinking about putting the headers in UR and then including them in SYCL.
You're right, this is what we will do.
There was a problem hiding this comment.
Done. I updated intel/llvm pr, then libdevice will re-use asan_libdevice.hpp in ur.
This flag is used to control error report process.
SYCLOS Part: intel/llvm#15326