Add umfInit/umfTearDown to urAdapterGet/urAdapterRelease #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
approved these changes
Aug 23, 2024
nrspruit
approved these changes
Aug 27, 2024
omarahmed1111
force-pushed
the
add-umfInit/umfTearDown-to-urAdapterGet/urAdapterRelease
branch
2 times, most recently
from
c2fd168
to
9e92cf8
Compare
omarahmed1111
commented
Aug 27, 2024
Comment on lines
+30
to
+35
| // This is a temporary workaround on windows, where UR adapter is teardowned | ||
| // before the UR loader, which will result in access violation when we use print | ||
| // function as the overrided print function was already released with the UR | ||
| // adapter. | ||
| // TODO: Change adapters to use a common sink class in the loader instead of | ||
| // using thier own sink class that inherit from logger::Sink. |
There was a problem hiding this comment.
Yeah, I think that's fine for now. Eventually, we could do a similar thing like here: #2000. Just keep a global instance of shared_ptr<> to the logger (here
) and every time get_logger is called, we would return shared_ptr instead of a reference.
omarahmed1111
force-pushed
the
add-umfInit/umfTearDown-to-urAdapterGet/urAdapterRelease
branch
from
9e92cf8
to
581a0d8
Compare
callumfare
approved these changes
Aug 27, 2024
nrspruit
approved these changes
Aug 27, 2024
igchor
approved these changes
Aug 27, 2024
This was referenced Aug 30, 2024
omarahmed1111
pushed a commit
to omarahmed1111/unified-runtime
that referenced
this pull request
Sep 10, 2024
…TearDown-to-urAdapterGet/urAdapterRelease Add umfInit/umfTearDown to urAdapterGet/urAdapterRelease
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As windows order of unloading dlls is reversed from linux, windows will call umfTearDown before it could release umf objects in level_zero, so we call umfInit on urAdapterGet and umfAdapterTearDown to enforce the teardown of umf
after umf objects are destructed.
Intel/llvm PR