Add support for static linking of the L0 adapter #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci/cd
pbalcer
force-pushed
the
static-linking
branch
2 times, most recently
from
e552c50
to
38ac63a
Compare
isaacault
reviewed
Jul 5, 2024
EwanC
approved these changes
Jul 5, 2024
isaacault
approved these changes
Jul 8, 2024
|
@nrspruit can you please take a look? |
|
@oneapi-src/unified-runtime-level-zero-write @oneapi-src/unified-runtime-maintain This is a nightmare to rebase (I'm not doing it again until I have a full set of approvals :-)), I'd appreciate a prompt review. |
kbenzie
approved these changes
Jul 11, 2024
pbalcer
force-pushed
the
static-linking
branch
3 times, most recently
from
d3ab0df
to
1c95ae4
Compare
|
intel/llvm build is failing with |
kswiecicki
reviewed
Jul 22, 2024
kswiecicki
force-pushed
the
static-linking
branch
8 times, most recently
from
1c4d81b
to
8939cfe
Compare
kswiecicki
force-pushed
the
static-linking
branch
6 times, most recently
from
7d8c910
to
2775137
Compare
kswiecicki
force-pushed
the
static-linking
branch
11 times, most recently
from
62b168d
to
e156b61
Compare
This patch adds a cmake option that builds the L0 adapter as a static library and then embeds its in the loader. The mechanim itself is fairly generic and, when a need arises, the same can be done for other adapters.
This option, marked as PUBLIC, is propagated to the targets linked with the 'ur_adapter_level_zero' target when the Level Zero adapter is built as a static library. This led to a STATUS_DLL_NOT_FOUND error when running test binaries on Windows.
kswiecicki
force-pushed
the
static-linking
branch
from
e156b61
to
3abe18c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a build-time option that builds the L0 adapter
as a static library and then embeds its in the loader.
The mechanim itself is fairly generic and, when a need arises,
the same can be done for other adapters.