[L0] Fix immediate command list use in Command Queues #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Jun 28, 2024
nrspruit
commented
- Keep track of all immediate command lists ensuring that they are not used in regular queues after they are placed back into the command list map.
nrspruit
requested review from
pbalcer and
igchor
and removed request for
a team
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Jun 28, 2024
pre-commit PR for oneapi-src/unified-runtime#1802 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
pbalcer
approved these changes
Jun 28, 2024
igchor
approved these changes
Jun 28, 2024
|
There's a failure in the Edit: That's gone away 👍 |
- Keep track of all immediate command lists ensuring that they are not used in regular queues after they are placed back into the command list map. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
kbenzie
force-pushed
the
fix_immediate_cmdlist_reuse
branch
from
d847710
to
665d4a6
Compare
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 5, 2024
pre-commit PR for oneapi-src/unified-runtime#1802 --------- Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com> Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com> Co-authored-by: Aaron Greig <aaron.greig@codeplay.com>
pbalcer
pushed a commit
to pbalcer/unified-runtime
that referenced
this pull request
Jul 5, 2024
…t_reuse [L0] Fix immediate command list use in Command Queues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.