[NATIVECPU] Report correct memory order capabilities for Native CPU #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwedolinsky
approved these changes
May 24, 2024
PietroGhg
force-pushed
the
pietro/report_atomics
branch
from
5f71674
to
53e4346
Compare
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Native CPU backend implements only
UR_MEMORY_ORDER_CAPABILITY_FLAG_RELAXED, but the adapter reports all the memory order capabilities. This PR addressed it by reporting onlyUR_MEMORY_ORDER_CAPABILITY_FLAG_RELAXED.intel/llvm PR: intel/llvm#13469
This makes it so the
AtomicRef/sub_local.cpp,AtomicRef/atomic_memory_order_acq_rel.cppandAtomicRef/load_local.cpptests (that check for the supported memory order capabilities) do not execute the unsupported atomics operations.