[UR] Improve handling of error cases in urProgramLink #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
force-pushed
the
ross/linkerror
branch
from
9afd1a2
to
783d419
Compare
kbenzie
reviewed
Mar 20, 2024
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1458 +/- ##
==========================================
- Coverage 14.82% 12.41% -2.41%
==========================================
Files 250 241 -9
Lines 36220 36293 +73
Branches 4094 4124 +30
==========================================
- Hits 5369 4506 -863
- Misses 30800 31783 +983
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
RossBrunton
force-pushed
the
ross/linkerror
branch
2 times, most recently
from
da9d876
to
0922999
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Mar 21, 2024
steffenlarsen
approved these changes
Mar 21, 2024
RossBrunton
force-pushed
the
ross/linkerror
branch
from
0922999
to
4a516fb
Compare
kbenzie
added
loader
RossBrunton
force-pushed
the
ross/linkerror
branch
2 times, most recently
from
4f47751
to
8da2cf1
Compare
github-actions
bot
added
the
experimental
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
May 22, 2024
RossBrunton
force-pushed
the
ross/linkerror
branch
from
8da2cf1
to
b5a6f3f
Compare
kbenzie
approved these changes
Jun 5, 2024
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jun 5, 2024
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jun 7, 2024
|
this has merged conflicts, please fix |
Unfortunately the job in intel/llvm#13085 is failing, so I'll need to look into that first when I get the chance. |
I don't see how rebasing this PR requires investigation into the intel/llvm failures. Sure, to get it merged they would need to not fail but that shouldn't be a blocker for rebasing this PR. |
RossBrunton
force-pushed
the
ross/linkerror
branch
from
b5a6f3f
to
955a681
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jul 9, 2024
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jul 9, 2024
Note that this change includes a specification change: urProgramLink now requires the output parameter to contain either nullptr or some unspecified binary on failure. As well as this change, a number of bugs have been fixed: * The Level Zero adapter now correctly returns `UR_RESULT_ERROR_PROGRAM_LINK_FAILURE` when linking fails, rather than `UR_RESULT_ERROR_UNKNOWN`. * A workaround has been added for some OpenCL devices that return `CL_INVALID_BINARY` rather than `CL_LINK_PROGRAM_FAILURE` on linker failure. * The `phProgram` handle is wrapped in a loader handle by the loader even if an error would be returned. This is required by Level Zero, which outputs a "dummy" program to store the linker log. Conformance tests have also been added.
RossBrunton
force-pushed
the
ross/linkerror
branch
from
955a681
to
25c75c0
Compare
RossBrunton
added a commit
to RossBrunton/intel-llvm
that referenced
this pull request
Jul 9, 2024
Pre-commit PR for oneapi-src/unified-runtime#1458 The wrapper logic for urProgramLink has also been updated to handle the change.
|
@oneapi-src/unified-runtime-native-cpu-write please review |
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 10, 2024
Pre-commit PR for oneapi-src/unified-runtime#1458 --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this change includes a specification change: urProgramLink now requires the output parameter to contain either nullptr or some unspecified binary on failure.
As well as this change, a number of bugs have been fixed:
UR_RESULT_ERROR_PROGRAM_LINK_FAILUREwhen linking fails, rather thanUR_RESULT_ERROR_UNKNOWN.CL_INVALID_BINARYrather thanCL_LINK_PROGRAM_FAILUREon linker failure.phProgramhandle is wrapped in a loader handle by the loader even if an error would be returned. This is required by Level Zero, which outputs a "dummy" program to store the linker log.Conformance tests have also been added.