[Bindless][CUDA] Add support for cubemaps #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
==========================================
- Coverage 14.82% 12.40% -2.42%
==========================================
Files 250 241 -9
Lines 36220 36311 +91
Branches 4094 4113 +19
==========================================
- Hits 5369 4506 -863
- Misses 30800 31801 +1001
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
isaacault
approved these changes
Mar 13, 2024
Seanst98
force-pushed
the
sean/cubemaps-UR
branch
from
00e0a4e
to
52f13d1
Compare
Seanst98
force-pushed
the
sean/cubemaps-UR
branch
from
52f13d1
to
97cc871
Compare
|
Friendly ping @oneapi-src/unified-runtime-cuda-write, @oneapi-src/unified-runtime-maintain, and @JackAKirk for reviews/approvals |
aarongreig
approved these changes
Mar 18, 2024
JackAKirk
approved these changes
Mar 18, 2024
Seanst98
force-pushed
the
sean/cubemaps-UR
branch
3 times, most recently
from
747e022
to
bda7c56
Compare
DBDuncan
approved these changes
Mar 20, 2024
Seanst98
force-pushed
the
sean/cubemaps-UR
branch
4 times, most recently
from
872548b
to
d7ec89a
Compare
Add enum to ur_mem_type_t to represent cubemap image type Add device aspects for cubemap support: - UR_DEVICE_INFO_CUBEMAP_SUPPORT_EXP - UR_DEVICE_INFO_CUBEMAP_SEAMLESS_FILTERING_SUPPORT_EXP Add structs/enums for cubemap sampling: - ur_exp_sampler_cubemap_properties_t struct to enable seamless filtering between cubemap faces - ur_exp_sampler_cubemap_filter_mode_t enum to enable distinguishing between cubemap seamless filtering options
Seanst98
force-pushed
the
sean/cubemaps-UR
branch
from
d7ec89a
to
3992a26
Compare
kbenzie
added
specification
kbenzie
pushed a commit
to kbenzie/unified-runtime
that referenced
this pull request
Apr 8, 2024
[Bindless][CUDA] Add support for cubemaps
aarongreig
added a commit
to aarongreig/unified-runtime
that referenced
this pull request
Apr 9, 2024
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 9, 2024
Add cubemap support: - Allocation and freeing of cubemapped images - Unsampled fetching and writing, and sampled reading - Device queries for cubemap support - Testing for both unsampled and sampled cubemap examples - Update the spec with cubemap support Remove `const` and `&` qualifiers from spec and implementation for handle parameters in `write_xxx` functions. Corresponding UR PR: oneapi-src/unified-runtime#1433 --------- Co-authored-by: Przemek Malon <przemek.malon@codeplay.com>
19 tasks
kbenzie
pushed a commit
that referenced
this pull request
Apr 17, 2024
[Bindless][CUDA] Add support for cubemaps
kbenzie
pushed a commit
to kbenzie/llvm
that referenced
this pull request
Apr 18, 2024
Add cubemap support: - Allocation and freeing of cubemapped images - Unsampled fetching and writing, and sampled reading - Device queries for cubemap support - Testing for both unsampled and sampled cubemap examples - Update the spec with cubemap support Remove `const` and `&` qualifiers from spec and implementation for handle parameters in `write_xxx` functions. Corresponding UR PR: oneapi-src/unified-runtime#1433 --------- Co-authored-by: Przemek Malon <przemek.malon@codeplay.com> Resolved Conflicts in: - Due to not cherry-picking intel#12840 - sycl/include/sycl/detail/pi.h - Due to not cherry-picking intel#13181 - sycl/include/sycl/device_aspect_macros.hpp - sycl/include/sycl/info/aspects.def
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add enum to ur_mem_type_t to represent cubemap image type
Add device aspects for cubemap support:
Add structs/enums for cubemap sampling:
Corresponding DPC++ PR: intel/llvm#12996