Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement urKernelGetSuggestedLocalWorkSize #1385

Merged
merged 63 commits into from
Jun 4, 2024
Merged

Implement urKernelGetSuggestedLocalWorkSize #1385

merged 63 commits into from
Jun 4, 2024

Conversation

yingcong-wu
Copy link
Contributor

@yingcong-wu yingcong-wu commented Feb 27, 2024 •
edited
Loading

This PR try to implement the API urKernelGetSuggestedLocalWorkSize, discussed in #1270.
SYCLOS PR: intel/llvm#12902

Also fix:

  • For Level-Zero: when LocalWorkSize is provided, urEnqueueKernelLaunch() will read LocalWorkSize without respecting workDim.

@yingcong-wu yingcong-wu changed the title WIP [WIP] Implement urQueueSuggestGroupSize Mar 4, 2024
@yingcong-wu yingcong-wu mentioned this pull request Mar 5, 2024
Merged
@yingcong-wu yingcong-wu assigned zhaomaosu and unassigned zhaomaosu Mar 6, 2024
@yingcong-wu yingcong-wu mentioned this pull request Mar 6, 2024
Closed
@yingcong-wu yingcong-wu changed the title [WIP] Implement urQueueSuggestGroupSize Implement urQueueSuggestGroupSize Mar 7, 2024
@yingcong-wu yingcong-wu changed the title Implement urQueueSuggestGroupSize [WIP] Implement urQueueSuggestGroupSize Mar 7, 2024
@yingcong-wu yingcong-wu marked this pull request as ready for review March 7, 2024 01:03
@yingcong-wu yingcong-wu requested review from a team as code owners March 7, 2024 01:03
@yingcong-wu yingcong-wu requested a review from ldrumm March 7, 2024 01:03
kbenzie
kbenzie reviewed Mar 7, 2024
View reviewed changes
scripts/core/queue.yml Outdated Show resolved Hide resolved
scripts/core/queue.yml Outdated Show resolved Hide resolved
@yingcong-wu yingcong-wu requested a review from kbenzie March 8, 2024 01:36
@yingcong-wu yingcong-wu changed the title [WIP] Implement urQueueSuggestGroupSize [WIP] Implement urKernelGetSuggestedLocalWorkSize Mar 8, 2024
AllanZyne
AllanZyne reviewed Mar 11, 2024
View reviewed changes
scripts/core/kernel.yml Outdated Show resolved Hide resolved
@zhaomaosu
Copy link
Contributor

Do we need to add some conformance tests?

wenju-he
wenju-he reviewed Mar 11, 2024
View reviewed changes
include/ur_api.h Outdated Show resolved Hide resolved
include/ur_api.h Outdated Show resolved Hide resolved
include/ur_api.h Outdated Show resolved Hide resolved
include/ur_api.h Outdated Show resolved Hide resolved
include/ur_api.h Outdated Show resolved Hide resolved
include/ur_api.h Show resolved Hide resolved
include/ur_api.h Outdated Show resolved Hide resolved
@yingcong-wu
Copy link
Contributor Author

Do we need to add some conformance tests?

Yang has asked me about this, but I can't think of anything meaningful. Do you have some ideas for adding tests for this?

@yingcong-wu
Copy link
Contributor Author

Kindly ping @kbenzie , @hdelan , @ldrumm , @pbalcer , @oneapi-src/unified-runtime-level-zero-write , please help review the PR, thank you very much!

hdelan
hdelan approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@hdelan hdelan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUDA and HIP adapters LGTM

@yingcong-wu
Copy link
Contributor Author

Kindly ping @oneapi-src/unified-runtime-level-zero-write , please help review the PR, thank you very much!

@yingcong-wu
Copy link
Contributor Author

Kindly ping @oneapi-src/unified-runtime-level-zero-write , please help review the PR, thank you very much!

@yingcong-wu
Copy link
Contributor Author

Kindly ping @oneapi-src/unified-runtime-level-zero-write , please help review the PR, thank you very much!

Hi @nrspruit, @raiyanla, @winstonzhang-intel, could you please review this PR. Thanks!

@yingcong-wu
Copy link
Contributor Author

Hi @nrspruit, @raiyanla, @winstonzhang-intel, could you please review this PR. Thanks!

nrspruit
nrspruit approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for level zero

@yingcong-wu
Copy link
Contributor Author

Hi @kbenzie, I got all the approval needed. How do you think I should proceed?

@kbenzie kbenzie added the ready to merge Added to PR's which are ready to merge label May 21, 2024
@kbenzie
Copy link
Contributor

kbenzie commented May 21, 2024

Hi @kbenzie, I got all the approval needed. How do you think I should proceed?

I've added the ready to merge label, its now in the merge queue so we'll merge this soon.

@yingcong-wu
Copy link
Contributor Author

Thank you!

@kbenzie
Copy link
Contributor

kbenzie commented Jun 4, 2024

Its unclear why the CodeQL Windows job is failing, its not an issue with this PR so I'll merge anyway.

@kbenzie kbenzie merged commit 755a1e7 into oneapi-src:main Jun 4, 2024
50 of 51 checks passed
sommerlukas pushed a commit to intel/llvm that referenced this pull request Jun 4, 2024
@yingcong-wu @kbenzie
[UR] Test for unified runtime PR (#12902)
781b75a 
UR PR: oneapi-src/unified-runtime#1385

---------

Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
@yingcong-wu yingcong-wu deleted the yc/new-api-suggestgroupsize branch September 13, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZyne AllanZyne AllanZyne left review comments

@pbalcer pbalcer pbalcer approved these changes

@kbenzie kbenzie kbenzie approved these changes

@wenju-he wenju-he wenju-he approved these changes

@ldrumm ldrumm ldrumm approved these changes

@nrspruit nrspruit nrspruit approved these changes

@PietroGhg PietroGhg PietroGhg approved these changes

@hdelan hdelan hdelan approved these changes

@zhaomaosu zhaomaosu Awaiting requested review from zhaomaosu

Assignees
No one assigned
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug native-cpu Native CPU adapter specific issues opencl OpenCL adapter specific issues ready to merge Added to PR's which are ready to merge sanitizer Sanitizer layer issues/changes/specification specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.