[UR] Add missing Threads library to common #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before oneapi-src#1216 adapters linked with disjoint_pool library that linked with Threads library. PR oneapi-src#1216 replace disjoint_pool with a version from UMF library that does not link with Threads lib explicitly which leads to compilation error on xmain. Fix this by explicitly adding adding Threads to ur_common.
|
LLVM testing PR: intel/llvm#12721 |
kbenzie
approved these changes
Feb 15, 2024
|
@kbenzie, could it be merged now? |
pbalcer
approved these changes
Feb 15, 2024
No, it looks like a fluke. We can ignore it. |
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Feb 15, 2024
oneapi-src/unified-runtime#1343 --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #1216 adapters linked with disjoint_pool library that linked with Threads library.
PR #1216 replace disjoint_pool with a version from UMF library that does not link with Threads lib explicitly which leads to compilation error on xmain. Fix this by explicitly adding adding Threads to ur_common.
Use the same logic as in
unified-runtime/source/common/umf_pools/CMakeLists.txt
Line 17 in f15234d