[Bindless][Exp] Add support for device to device copies between CuArrays #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
- Coverage 14.82% 12.43% -2.40%
==========================================
Files 250 241 -9
Lines 36220 36242 +22
Branches 4094 4111 +17
==========================================
- Hits 5369 4506 -863
- Misses 30800 31732 +932
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
Seanst98
approved these changes
Jan 22, 2024
isaacault
approved these changes
Jan 23, 2024
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
from
0942022
to
ae481ab
Compare
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
2 times, most recently
from
7748492
to
a4a78a0
Compare
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
5 times, most recently
from
ba3ab17
to
2ae14b1
Compare
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
from
2ae14b1
to
fff3045
Compare
kbenzie
changed the title
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
from
fff3045
to
28df2c2
Compare
DBDuncan
approved these changes
Mar 1, 2024
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
from
28df2c2
to
aa04d5d
Compare
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
from
aa04d5d
to
a46b6c0
Compare
isaacault
requested changes
Mar 5, 2024
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
from
a46b6c0
to
4a93adc
Compare
isaacault
requested changes
Mar 12, 2024
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
2 times, most recently
from
a282c4c
to
72ab43d
Compare
isaacault
approved these changes
Mar 20, 2024
isaacault
requested changes
Mar 21, 2024
There was a problem hiding this comment.
Sorry for just noticing this now, but can the title and description of this PR be updated to remove mention of the mem handle?
This PR doesn't touch any mem handles, and any comments about it don't belong in this project but rather in intel/llvm. This PR is strictly about implementing D2D copies.
cppchedy
changed the title
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
from
72ab43d
to
5d9b46b
Compare
isaacault
requested changes
Mar 26, 2024
isaacault
approved these changes
Mar 29, 2024
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
from
bea263c
to
f894c7f
Compare
DBDuncan
approved these changes
Apr 11, 2024
DBDuncan
reviewed
Apr 11, 2024
przemektmalon
approved these changes
Apr 11, 2024
* support device to device copies between CUarrays * fix random failure by sync on stream when dispatching copies * add support for image arrays and cubemaps copies
cppchedy
force-pushed
the
chedy/device-to-device-copy
branch
from
cc3b814
to
f9fb116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Cuarrayscorresponding PR in intel/llvm#12449