Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPC tests (umfIpcTest) to the devdax provider #845

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Add IPC tests (umfIpcTest) to the devdax provider #845

merged 3 commits into from
Nov 4, 2024

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Oct 28, 2024 •
edited
Loading

Description

Add IPC tests (umfIpcTest) to the devdax provider.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau mentioned this pull request Oct 28, 2024
Closed
3 tasks
@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch 3 times, most recently from 7ad3d15 to 0685486 Compare October 29, 2024 09:03
@ldorau ldorau mentioned this pull request Oct 29, 2024
Closed
@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch from 135902a to 1d2b1d5 Compare October 30, 2024 10:03
@ldorau
Copy link
Contributor Author

ldorau commented Oct 30, 2024

See the issue: #846

@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch from 1d2b1d5 to b96b7e3 Compare October 30, 2024 15:10
@ldorau ldorau mentioned this pull request Oct 30, 2024
Merged
3 tasks
@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch 2 times, most recently from 9adda39 to e0c08bb Compare October 31, 2024 14:27
@ldorau
Make error messages in utils_mmap_file() more verbose
ff242b7 
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch from e0c08bb to 7816b4a Compare October 31, 2024 15:15
@ldorau ldorau marked this pull request as ready for review October 31, 2024 15:16
@ldorau ldorau requested a review from a team as a code owner October 31, 2024 15:16
@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch from 7816b4a to 96a335c Compare October 31, 2024 15:42
vinser52
vinser52 requested changes Oct 31, 2024
View reviewed changes
test/provider_devdax_memory.cpp Outdated Show resolved Hide resolved
test/ipcFixtures.hpp Outdated Show resolved Hide resolved
@ldorau ldorau requested review from vinser52, a team and bratpiorka October 31, 2024 16:09
@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch from 96a335c to 79b8d2a Compare October 31, 2024 21:26
vinser52
vinser52 requested changes Nov 1, 2024
View reviewed changes
test/provider_devdax_memory.cpp Outdated Show resolved Hide resolved
test/provider_os_memory.cpp Show resolved Hide resolved
test/ipcFixtures.hpp Outdated Show resolved Hide resolved
@ldorau
Enable running umfIpcTest tests when free() is not supported
ed0332a 
Some memory providers (currently the devdax and the file providers)
do not support the free() operation (free() always returns
the UMF_RESULT_ERROR_NOT_SUPPORTED error).

Add the `free_not_supp` parameter to `ipcTestParams` in ipcFixtures.hpp
that says if the provider does not support the free() op
to enable running umfIpcTest tests when free() is not supported.

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch 7 times, most recently from fba7fe9 to 41021ac Compare November 4, 2024 08:26
@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch from 41021ac to ca20ebb Compare November 4, 2024 08:30
@ldorau ldorau requested a review from vinser52 November 4, 2024 08:45
@ldorau ldorau mentioned this pull request Nov 4, 2024
Merged
4 tasks
@ldorau
Add IPC tests (umfIpcTest) to the devdax provider
486b3e4 
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau ldorau force-pushed the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch from ca20ebb to 486b3e4 Compare November 4, 2024 14:47
@ldorau ldorau requested a review from vinser52 November 4, 2024 14:48
@ldorau ldorau mentioned this pull request Nov 4, 2024
Merged
7 tasks
@bratpiorka bratpiorka marked this pull request as draft November 4, 2024 16:54
@bratpiorka
Copy link
Contributor

@ldorau switched to draft - what do you think - should we merge #761 first? Let's discuss this offline

@vinser52
Copy link
Contributor

vinser52 commented Nov 4, 2024

@ldorau switched to draft - what do you think - should we merge #761 first? Let's discuss this offline

I have two questions/comments:

  1. Why we should postpone merging additional tests?
  2. Before merging enable tracker in ProxyLib by default #761 I suggest to agree on design first.

@bratpiorka bratpiorka marked this pull request as ready for review November 4, 2024 17:03
@bratpiorka
Copy link
Contributor

ok we can merge this if CI passes

@ldorau ldorau merged commit cdc0310 into oneapi-src:main Nov 4, 2024
74 checks passed
@ldorau ldorau deleted the Add_IPC_tests_umfIpcTest_to_the_devdax_provider branch November 5, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@vinser52 vinser52 vinser52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldorau @bratpiorka @vinser52