Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sles15 to multi numa ci #1007

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

intel12232289
Copy link

Add sles15 to multi numa ci

@lukaszstolarczuk
Copy link
Contributor

@ldorau
Copy link
Contributor

ldorau commented Dec 20, 2024

using static hwloc linking (changes: https://github.com/intel12232289/unified-memory-framework/blob/refs/heads/Add-SLES15-to-multi-NUMA-C/.github/workflows/reusable_multi_numa.yml#L49 )

we got issues in testing, is this expected?

I think it is not, since it works correctly on Ubuntu 22.04;
https://github.com/oneapi-src/unified-memory-framework/actions/runs/12427135597/job/34696473613

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, @intel12232289 it looks like there's some issue we may not understand.

Please make it as it was before - run only selected tests (similarly to RHEL), and please make the PR ready for review & merge

@@ -15,11 +15,11 @@ jobs:
multi_numa:
name: "${{matrix.os}}, ${{matrix.build_type}}, shared=${{matrix.shared_library}}"
# run only on upstream; forks will not have the HW
if: github.repository == 'oneapi-src/unified-memory-framework'
# if: github.repository == 'oneapi-src/unified-memory-framework'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls uncomment this

.github/workflows/reusable_multi_numa.yml Outdated Show resolved Hide resolved
.github/workflows/reusable_multi_numa.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants