Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPC API of the file provider does not work #848

Closed
ldorau opened this issue Oct 29, 2024 · 1 comment · Fixed by #865
Closed

IPC API of the file provider does not work #848

ldorau opened this issue Oct 29, 2024 · 1 comment · Fixed by #865
Assignees
@ldorau
Labels
bug Something isn't working

Comments

@ldorau
Copy link
Contributor

ldorau commented Oct 29, 2024

IPC API of the file provider does not work.

Ref: #847

Environment Information

  • UMF version (hash commit or a tag): b3bbdd4
  • OS(es) version(s): Linux

Please provide a reproduction of the bug:

See: #847
See: https://github.com/oneapi-src/unified-memory-framework/actions/runs/11572419084/job/32212568727?pr=847

How often bug is revealed:

always
@ldorau ldorau added the bug Something isn't working label Oct 29, 2024
@ldorau ldorau self-assigned this Oct 29, 2024
@ldorau ldorau mentioned this issue Oct 30, 2024
Merged
4 tasks
@ldorau
Copy link
Contributor Author

ldorau commented Oct 30, 2024

@vinser52 @bratpiorka @lplewa

ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 5, 2024
@ldorau
Fix file_alloc() and file_open/close_ipc_handle()
3a14747 
Alignment passed to `file_alloc()` must be a power of two
and a multiple or a divider of the page size.
Align up the alignment in `file_alloc()` to the page size.

file_open_ipc_handle() has to use the memory protection
and visibility got from the IPC handle, so let's add
the memory protection and visibility to the IPC handle.

A length and an offset passed to mmap()
in `file_open_ipc_handle()` and `file_close_ipc_handle()`
have to be aligned to the page size.

Ref: oneapi-src#838

Fixes: oneapi-src#848

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau ldorau mentioned this issue Nov 5, 2024
Merged
3 tasks
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 5, 2024
@ldorau
Fix file_alloc() and file_open/close_ipc_handle()
faa4de6 
Alignment passed to `file_alloc()` must be a power of two
and a multiple or a divider of the page size.
Align up the alignment in `file_alloc()` to the page size.

file_open_ipc_handle() has to use the memory protection
and visibility got from the IPC handle, so let's add
the memory protection and visibility to the IPC handle.

A length and an offset passed to mmap()
in `file_open_ipc_handle()` and `file_close_ipc_handle()`
have to be aligned to the page size.

Ref: oneapi-src#838

Fixes: oneapi-src#848

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 5, 2024
@ldorau
Fix file_alloc() and file_open/close_ipc_handle()
7edcd28 
Alignment passed to `file_alloc()` must be a power of two
and a multiple or a divider of the page size.
Align up the alignment in `file_alloc()` to the page size.

file_open_ipc_handle() has to use the memory protection
and visibility got from the IPC handle, so let's add
the memory protection and visibility to the IPC handle.

A length and an offset passed to mmap()
in `file_open_ipc_handle()` and `file_close_ipc_handle()`
have to be aligned to the page size.

Ref: oneapi-src#838

Fixes: oneapi-src#848

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau ldorau closed this as completed in aada873 Nov 5, 2024
ldorau added a commit to ldorau/unified-memory-framework that referenced this issue Nov 6, 2024
@ldorau
Fix file_alloc() and file_open/close_ipc_handle()
54318b9 
Alignment passed to `file_alloc()` must be a power of two
and a multiple or a divider of the page size.
Align up the alignment in `file_alloc()` to the page size.

file_open_ipc_handle() has to use the memory protection
and visibility got from the IPC handle, so let's add
the memory protection and visibility to the IPC handle.

Ref: oneapi-src#838

Fixes: oneapi-src#848

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldorau ldorau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix file_alloc() and file_open/close_ipc_handle() ldorau/unified-memory-framework
1 participant
@ldorau