Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KT] Remove algorithms from oneapi::dpl::experimental::kt::esimd #1910

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[KT] Remove algorithms from oneapi::dpl::experimental::kt::esimd #1910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
383e094
[KT] Remove deprecated namespace
dmitriy-sobolev Oct 17, 2024
ca54ed1
Remove namespace usage in a test
dmitriy-sobolev Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions include/oneapi/dpl/experimental/kt/esimd_radix_sort.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,18 +172,4 @@ radix_sort_by_key(sycl::queue __q, _KeysIterator1 __keys_first, _KeysIterator1 _

} // namespace oneapi::dpl::experimental::kt::gpu::esimd

namespace oneapi::dpl::experimental::kt
{
namespace esimd
#if !defined(__SYCL_DEVICE_ONLY__)
[[deprecated("Use of oneapi::dpl::experimental::kt::esimd namespace is deprecated "
"and will be removed in a future release. "
"Use oneapi::dpl::experimental::kt::gpu::esimd instead")]]
#endif
{
using oneapi::dpl::experimental::kt::gpu::esimd::radix_sort;
using oneapi::dpl::experimental::kt::gpu::esimd::radix_sort_by_key;
} // namespace oneapi::dpl::experimental::kt::esimd
} // namespace oneapi::dpl::experimental::kt

#endif // _ONEDPL_KT_ESIMD_RADIX_SORT_H
13 changes: 2 additions & 11 deletions test/kt/esimd_radix_sort.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,18 +123,9 @@ test_sycl_iterators(sycl::queue q, std::size_t size, KernelParam param)
std::stable_sort(std::begin(ref), std::end(ref), Compare<T, IsAscending>{});
{
sycl::buffer<T> buf(input.data(), input.size());

#ifdef __clang__
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
#endif
// Deprecated namespace is used deliberatelly to make sure the functionality is still available
oneapi::dpl::experimental::kt::esimd::radix_sort<IsAscending>(q, oneapi::dpl::begin(buf), oneapi::dpl::end(buf),
param)
oneapi::dpl::experimental::kt::gpu::esimd::radix_sort<IsAscending>(q, oneapi::dpl::begin(buf), oneapi::dpl::end(buf),
param)
.wait();
#ifdef __clang__
#pragma clang diagnostic pop
#endif
}

std::string msg = "wrong results with oneapi::dpl::begin/end, n: " + std::to_string(size);
Expand Down
Loading