Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oneDPL][ranges] + fix for std::ranges::sort using (windows); #1885

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[oneDPL][ranges] + fix for std::ranges::sort using (windows); #1885

merged 1 commit into from
Oct 8, 2024

Conversation

MikeDvorskiy
Copy link
Contributor

@MikeDvorskiy MikeDvorskiy commented Oct 7, 2024 •
edited
Loading

  1. Microsoft standard libraries older than _MSC_VER == 1939 have std::ranges:: definition as a function instead of a global function object. It leads to an error in oneDPL implementation. The PR fixes this issue via a workaround. https://godbolt.org/z/sTfcsj897
  2. Added _ONEDPL_STD_RANGES_WINDOWS_NON_GLOBAL_FUN_OBJ macro

@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/ranges_sort_wndows_fix branch from 5aa8ff3 to 64688b1 Compare October 7, 2024 15:11
dmitriy-sobolev
dmitriy-sobolev approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The clang-format suggestions look optional to me.

@MikeDvorskiy MikeDvorskiy merged commit db9e414 into main Oct 8, 2024
21 of 22 checks passed
@MikeDvorskiy MikeDvorskiy deleted the dev/mdvorski/ranges_sort_wndows_fix branch October 8, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitriy-sobolev dmitriy-sobolev dmitriy-sobolev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeDvorskiy @dmitriy-sobolev