-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: workflows: Enable graph builds for aarch64 CI #2168
Conversation
a671065
to
dc03df2
Compare
Signed-off-by: Hamza Butt <hamza.butt@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@mgouicem I did need to touch a graph file, but I think you might be able to also approve considering the trivial change (we have also done this change before in the PR I linked), in case we don't get a review from the graph team. |
It seems this is making macOS CI fail.
This test should not be running though (usm CPU should be a thing only for SYCL CPU configuration, which is not a thing at all on macOS [and maybe even ARM?]). |
@mgouicem , it's the bad naming for the test. Even it's not SYCL runtime, "usm" is appended into the test name. The is an internal PR fixing the test names. @ElaineBao is working on that. |
@TaoLv whatever the new name is, do we need to add it to the test exclusions list for MacOS? But I am surprised how this happened, because the CI for this PR passed. |
Yes. I see you already added |
Enabling graph builds in the CI so we can monitor breakages for aarch64. To do this, I had to deal with solving some aarch64 compiler warnings, same as those that appeared in #2118. So I adopted the same resolution as suggested for that PR.
For MacOS we only test graph for release mode with clang as the smoke tests take too long in debug mode (1 hour+).
Fixes #2137.