Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: workflows: Enable graph builds for aarch64 CI #2168

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

theComputeKid
Copy link
Member

@theComputeKid theComputeKid commented Oct 15, 2024

Enabling graph builds in the CI so we can monitor breakages for aarch64. To do this, I had to deal with solving some aarch64 compiler warnings, same as those that appeared in #2118. So I adopted the same resolution as suggested for that PR.

For MacOS we only test graph for release mode with clang as the smoke tests take too long in debug mode (1 hour+).

Fixes #2137.

@theComputeKid theComputeKid requested review from a team as code owners October 15, 2024 10:36
@github-actions github-actions bot added the devops Github automation label Oct 15, 2024
@theComputeKid theComputeKid force-pushed the ci branch 2 times, most recently from a671065 to dc03df2 Compare October 15, 2024 10:41
Signed-off-by: Hamza Butt <hamza.butt@arm.com>
Copy link
Contributor

@Radu2k Radu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@theComputeKid
Copy link
Member Author

theComputeKid commented Oct 17, 2024

@mgouicem I did need to touch a graph file, but I think you might be able to also approve considering the trivial change (we have also done this change before in the PR I linked), in case we don't get a review from the graph team.

@mgouicem mgouicem merged commit d71d85c into oneapi-src:main Oct 17, 2024
25 checks passed
@mgouicem
Copy link
Contributor

It seems this is making macOS CI fail.

The following tests FAILED:
	160 - test_graph_unit_dnnl_mqa_decomp_usm_cpu (SEGFAULT)

This test should not be running though (usm CPU should be a thing only for SYCL CPU configuration, which is not a thing at all on macOS [and maybe even ARM?]).

@TaoLv
Copy link
Contributor

TaoLv commented Oct 18, 2024

@mgouicem , it's the bad naming for the test. Even it's not SYCL runtime, "usm" is appended into the test name. The is an internal PR fixing the test names. @ElaineBao is working on that.

@theComputeKid
Copy link
Member Author

@TaoLv whatever the new name is, do we need to add it to the test exclusions list for MacOS? But I am surprised how this happened, because the CI for this PR passed.

@TaoLv
Copy link
Contributor

TaoLv commented Oct 18, 2024

Yes. I see you already added SKIPPED_TEST_FAILURES+="|test_graph_unit_dnnl_sdp_decomp_usm_cpu" in this PR. I feel test_graph_unit_dnnl_mqa_decomp_usm_cpu should be handled in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Github automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build of 3.5.3 fails when both ACL and graph are enabled
5 participants