Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kpi 2.0 #27

Merged
merged 736 commits into from
Jan 27, 2021
Merged

Kpi 2.0 #27

merged 736 commits into from
Jan 27, 2021

Conversation

WinnyTroy
Copy link

@WinnyTroy WinnyTroy commented Sep 17, 2020 •
edited
Loading

Changes Implemented

Rebased ona-custom-changes with remote Kobotoolbox KPI two-databases branch

Partly resolves #26

noliveleger and others added 30 commits September 17, 2020 15:53
@noliveleger @WinnyTroy
Exclude KoBoCat internal permission assignments from ViewSet list
5f5cb29
@noliveleger @WinnyTroy
Use object.remove_perm() to bulk delete permission assignments prio…
15fb372 
…r to assign new ones.
@duvld @WinnyTroy
new branch same issue, fixed all the comments in pull request 2500 as…
d973128 
… well
@jnm @WinnyTroy
Add KPI identifier to service_health response
8e0310d 
and use the KoBoCAT response `text` (a `str`) instead of the `content`,
which is `bytes`
@magicznyleszek @WinnyTroy
fix AccessDenied import usage - consistent with other ui.es6 ones
5543bbb
@noliveleger @WinnyTroy
Renamed AssetEditorNestedObjectPermission to a less confusing name
54e6ded
@magicznyleszek @WinnyTroy
start rebuilding styles for service-row
07e8017
@magicznyleszek @WinnyTroy
align columns
b766e2d
@magicznyleszek @WinnyTroy
fix z-indexes
3a125c9
@jnm @WinnyTroy
Remove USE_SAME_DATABASE code
faccf4c 
since it's no longer possible for KPI and KoBoCAT to share a database
@jnm @WinnyTroy
Add checks for two-database upgrade problems
618cfe8 
Towards kobotoolbox#2543
@jnm @WinnyTroy
Add management command to check for empty database
29b60ff 
Will be used by kobo-install; see kobotoolbox/kobo-install#65
@jnm @WinnyTroy
Re-raise unrecognized OperationalErrors
7b4397d
@jnm @WinnyTroy
Add management command that waits for database…
e4ad3a4 
to begin accepting connections
@jnm @WinnyTroy
Resolve SyntaxWarning: "is" with a literal
8e4c57d
@jnm @WinnyTroy
Don't complain if KoBoCAT database has no KPI data
1a5a68f 
…when running two-database migration checks
@duvld @WinnyTroy
WIP: getting download URL for media files
77d5b61
@duvld @WinnyTroy
geopoint query limit removed if a specific question is queried
13ab5b7
@duvld @WinnyTroy
removed console logs
c650e47
@duvld @WinnyTroy
WIP: asset values causing cross-domin error when fetching
15b5304
@duvld @WinnyTroy
WIP: got links to display in table, now need to get real links
358c1e8
@duvld @WinnyTroy
Displays correct url in table view for media links
06eba79
@duvld @WinnyTroy
replaced .some with .forEach
593690b
@duvld @WinnyTroy
only remove 5000 limit if viewby exists
1da4e6f
@duvld @WinnyTroy
made links open in new tab on click
ef5de24
@jnm @WinnyTroy
Update actions import
be58ca5
@jnm @WinnyTroy
Update actions import
1497789
@jnm @WinnyTroy
Make sure user matches when validating permissions
fc369e5
@magicznyleszek @WinnyTroy
fix tests and fix vendor splitting for npm run watch
63ecb40
@duvld @WinnyTroy
moved changes to map.es6 from dataInteface.es6
6f20a10
WinnyTroy and others added 6 commits September 17, 2020 16:14
@WinnyTroy
Include aability to grant default model level perms to authenticated …
85ee644 
…user
@WinnyTroy
Remove 'Return to list' and 'close' icons from landing page when crea…
c598506 
…ting a form
@WinnyTroy
Remove ONA_TITLE constant from the utils file to the config file.
ad7298d 
Rename vars from ONA_TITLE to WEB_PAGE_TITLE
@ivermac @WinnyTroy
Prevent deployment for non-survey assets
300a790 
Show successful update message when non-survey assets have been successfully updated

Signed-off-by: Mark Ekisa <mark.ekisa@gmail.com>
@ivermac @WinnyTroy
Add can_publicize_collection key to extra_details json object
4f1a499 
Signed-off-by: Mark Ekisa <mark.ekisa@gmail.com>
@WinnyTroy
Update raven pip package
1c6e29b
@WinnyTroy WinnyTroy marked this pull request as ready for review September 17, 2020 13:18
@WinnyTroy WinnyTroy mentioned this pull request Sep 17, 2020
Closed
13 tasks
@WinnyTroy WinnyTroy force-pushed the kpi_2.0 branch 7 times, most recently from 9943bf2 to 499e4bc Compare September 24, 2020 11:40
WinnyTroy and others added 2 commits October 7, 2020 09:35
@WinnyTroy
Update KPI authentication Module (#28)
da678c3 
* Get authentication model from kobocat db
Use Token object to retrieve Onadata user associated with Token. Fetch username for Onadata User
Get or Create KPI User from Ondata user username and email var

* Grant permissions when creating user object.

* Return tuple with new KPI user and token

* Handle Token.DoesNotExist error

* Return namespace in urls, instead have this present in the permission endpoint
@WinnyTroy
Rebase with kobo/two_databases
c83d93f
ivermac and others added 3 commits November 10, 2020 10:12
@ivermac @WinnyTroy
Retrieve form json payload from onadata then update asset
f89668b 
Signed-off-by: Mark Ekisa <mark.ekisa@gmail.com>
@WinnyTroy
Remove updates to Kobo linking forms on Kobo to assets on KPI (#32)
4e0da71
@WinnyTroy
Updates to the imports Endpoint. (#35)
e352ac0 
* Authenticate user from Onadata db when making requests to import the form url into KPI and also when fetching form information from Onadata.

* code cleanup
@WinnyTroy WinnyTroy requested a review from ivermac January 27, 2021 09:20
ivermac
ivermac approved these changes Jan 27, 2021
View reviewed changes
Copy link

@ivermac ivermac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please create an issue for this PR before merging. The issue should have a general description of what this PR is fixing/adding

@WinnyTroy WinnyTroy merged commit f2765af into ona-custom-changes Jan 27, 2021
@WinnyTroy WinnyTroy deleted the kpi_2.0 branch August 13, 2021 12:38
@DavisRayM DavisRayM restored the kpi_2.0 branch October 26, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivermac ivermac ivermac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@WinnyTroy @ivermac @noliveleger @duvld @jnm @magicznyleszek @p2edwards @gushil @dorey