osd_df and cluster_df methods

[oms4suse]

We want osd_df and cluster_df methods to allow us to check if the cluster is empty when removing osd's

[l-mb]

Do the temporary variables make sense? You could either directly construct it in the return statement ("id" : node.get("id")) or iterate over a set of keywords and build it up like that? Or use a list comprehension maybe? http://stackoverflow.com/questions/1747817/create-a-dictionary-with-list-comprehension-in-python

[oms4suse]

Temporary variables provide little advantage without error checking for None. The only real advantage is code clarity.

As for list comprehension, This would make sense if the input and output fields where identical.

I felt that particularly "crush_weight" was more ceph implementation specific, and "weight_crush" being presented to the user (and stored in the model) was easier to understand since it would (in default representation of json by python it is sorted alphabetically) be next to "crush_weight".

Which would you prefer?

I add a comment explaining the rational, or move to list comprehension?

[l-mb]

I'd think that sticking to the ceph naming would probably be easier to understand, even if it is not the naming I'd have chosen (because then we're consistent with how ceph calls things and users don't have to remember multiple naming schemes).

[jan--f]

I would agree, either directly construct in return statement or list comprehension/dict comprehension if keys stay the same. Direct construction would make key change obvious enough I guess.