Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): run rendering process in a Sandbox Environment #667

Merged

Conversation

fschuch
Copy link
Member

@fschuch fschuch commented Dec 13, 2024

What

Change the Job Template process to run inside a Jinja Sandbox Enrivonment.

Why

Secure the process.


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

@fschuch fschuch force-pushed the fix(api)--run-rendering-process-in-a-Sandbox-Environment branch 3 times, most recently from 66a6b28 to 675dcce Compare December 13, 2024 15:50
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (326d36d) to head (4a19d1c).
Report is 1 commits behind head on release/5.4.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/5.4     #667      +/-   ##
===============================================
+ Coverage        92.57%   92.58%   +0.01%     
===============================================
  Files               85       85              
  Lines             4483     4490       +7     
===============================================
+ Hits              4150     4157       +7     
  Misses             333      333              
Flag Coverage Δ
agent 92.80% <ø> (ø)
api 95.33% <ø> (+0.01%) ⬆️
cli 88.62% <ø> (+0.02%) ⬆️
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fschuch fschuch force-pushed the fix(api)--run-rendering-process-in-a-Sandbox-Environment branch from 675dcce to 27f9a12 Compare December 13, 2024 16:06
@fschuch fschuch force-pushed the fix(api)--run-rendering-process-in-a-Sandbox-Environment branch from 27f9a12 to 4a19d1c Compare December 13, 2024 16:11
@fschuch fschuch merged commit 58a8b7f into release/5.4 Dec 13, 2024
13 checks passed
@fschuch fschuch deleted the fix(api)--run-rendering-process-in-a-Sandbox-Environment branch December 13, 2024 16:14
@fschuch fschuch restored the fix(api)--run-rendering-process-in-a-Sandbox-Environment branch December 16, 2024 12:35
@fschuch fschuch deleted the fix(api)--run-rendering-process-in-a-Sandbox-Environment branch December 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants