-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to run a different reducer instead of returning the a static initialState #5
Conversation
I've explaind the change in the README 73e23c6 |
root = true | ||
|
||
[*] | ||
indent_style = tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this file from the PR? When I squash and merge we'd have two separate changes in one comment. Also, I used spaces across the project 😅
Feel free to create a new PR for .editorconfig
Thanks a lot - this definitely looks interesting! I've added some comments to the files 😉 |
@@ -49,6 +50,19 @@ combineReducers({ | |||
|
|||
Now, once you click the increment button, the state will be reset to `0`. | |||
|
|||
if you need more complex initialization logic you can provide a `reducer function` as the last param it willadd be used to get the inital state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes: If you need more complex initialization logic, you can provide a reducer function as the last param. It will be called with the state and action to get the initial state.
@arikmaor I've added a comment for a minor text improvement, once it's fixed this should be ready 😄 |
@arikmaor sorry to bother you again, but can you pin eslint to |
lint still fails with this output:
|
@arikmaor Thanks for all your efforts! I cloned your repo and managed to get it to work by also pinning the |
seems to work, thanks :) |
I think it can be a common case for example: