Skip to content

Commit

Permalink
Some improvements and fixes in the workflows (#649)
Browse files Browse the repository at this point in the history
  • Loading branch information
mauvilsa authored Dec 20, 2024
1 parent 98ccf7f commit 9d55863
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/codeql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,14 @@ jobs:
contents: read
security-events: write

strategy:
fail-fast: false
matrix:
language: [python]

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
languages: python
queries: +security-and-quality
config-file: ./.github/codeql-config.yaml

Expand All @@ -39,4 +34,4 @@ jobs:
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
with:
category: "/language:${{ matrix.language }}"
category: "/language:python"
5 changes: 2 additions & 3 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
- name: without optional dependencies
run: |
pip install .[coverage]
pip uninstall -y argcomplete
pytest --cov --cov-report=term --cov-report=xml --junit-xml=junit.xml
mv coverage.xml coverage_py${{ matrix.python }}_bare.xml
mv junit.xml junit_py${{ matrix.python }}_bare.xml
Expand Down Expand Up @@ -76,7 +75,7 @@ jobs:
with:
python-version: ${{ matrix.python }}
cache: pip
- run: pip install tox
- run: pip install --disable-pip-version-check tox
- run: tox -e py-all-extras

omegaconf:
Expand Down Expand Up @@ -246,7 +245,7 @@ jobs:
pypi-publish:
if: startsWith(github.ref, 'refs/tags/v')
runs-on: ubuntu-latest
needs: [linux, windows, macos, omegaconf, pydantic-v1, installed-package, doctest]
needs: [linux, windows, macos, omegaconf, pydantic-v1, installed-package, doctest, mypy]
environment:
name: pypi
url: https://pypi.org/p/jsonargparse
Expand Down

0 comments on commit 9d55863

Please sign in to comment.