Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ru translation improvements #331

Merged
merged 4 commits into from
Jul 29, 2016
Merged

ru translation improvements #331

merged 4 commits into from
Jul 29, 2016

Conversation

strobil
Copy link
Contributor

@strobil strobil commented Jul 29, 2016

Fixed typo mistakes, added new translation strings.

@@ -70,5 +70,8 @@
<string name="notification_service_pokemon_in_area">%1$d покемон в досягаемости:</string>
<string name="meters">метров</string>
<string name="toast_google_login_error">Ошибка входа через аккаунт Google</string>

<string name="toast_still_searching">Поиск&#8230; найден %1$d Pokémon поблизости.</string>
<string name="preset_themes_title">Предустановленые темы</string>
Copy link
Contributor

@fess89 fess89 Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "Предустановленные", not "Предустановленые"

@@ -24,12 +24,12 @@
<string name="toast_credentials">Невозможно войти. Проверьте выши данные для входа</string>
<string name="title_activity_poke_map">Покемон Рядом</string>
Copy link
Contributor

@fess89 fess89 Jul 29, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be "Покемон рядом", not "Покемон Рядом"
which also stands for every such case of capitalization (e.g. "Введите пароль", not "Введите пароль")

@@ -70,5 +70,8 @@
<string name="notification_service_pokemon_in_area">%1$d покемон в досягаемости:</string>
<string name="meters">метров</string>
<string name="toast_google_login_error">Ошибка входа через аккаунт Google</string>

<string name="toast_still_searching">Поиск&#8230; найден %1$d Pokémon поблизости.</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For english-speaking: problem with plurals in russian that makes this sentence (and some other) sound not very good with some numbers.

Я бы поменял на Поиск&#8230; Покемонов найдено поблизости: %1$d.
В текущем варианте перевод подходит только для чисел оканчивающихся на 1 (для сравнения:
найден 0 Pokémon поблизости | Покемонов найдено поблизости: 0
найден 1 Pokémon поблизости | Покемонов найдено поблизости: 1
найден 21 Pokémon поблизости | Покемонов найдено поблизости: 21
найден 2 Pokémon поблизости | Покемонов найдено поблизости: 2
найден 5 Pokémon поблизости | Покемонов найдено поблизости: 5
Такая же проблема с notification_service_pokemon_in_area и notification_service_pokemon_near. Возможно есть еще подобные места

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could write a pluralizer for that... but for the time being, your solution is OK

@omkarmoghe omkarmoghe merged commit 1c3a70d into omkarmoghe:dev Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants