Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capitalize End Site in BVH file #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seanschneeweiss
Copy link

Thank you for this great project, it really helped us a lot for our project RoseMotion.

Matlab requires to use End Site in the BVH file, so that the BVH importer identifies the end of the skeleton.

Do you think this change could break the behavior of other tools?

@omimo
Copy link
Owner

omimo commented Apr 7, 2021

I'm glad you found PyMO useful.

I'll have to run some tests to make sure the exported BVH files load properly in some major tools. I'll get back to you.

@omimo omimo self-assigned this Apr 7, 2021
@seanschneeweiss
Copy link
Author

seanschneeweiss commented Apr 7, 2021

Thank you very much for testing. Could also be a bug in MATLAB :)
Will test soon if it still persists in the newest MATLAB version.

@seanschneeweiss
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants