-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document PE Bounty and Bond Design #702
Conversation
There could have been another approach, where without combining the values in struct, we try to compare and return the max value between the bond and bounty, but I think this is cleaner? |
Co-authored-by: thec00n <thec00n@fork.at>
Co-authored-by: thec00n <thec00n@fork.at>
Co-authored-by: thec00n <thec00n@fork.at>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good, I've added some definitions and edited for clarity in some places
Co-authored-by: Kevin Sullivan <4653170+kevsul@users.noreply.github.com>
Co-authored-by: thec00n <thec00n@fork.at>
**_On succesfull challenge:_** | ||
*Bond -> from `Exit Game Contract` to `Challenger`* | ||
|
||
The **Exit Processor** gets the bounty as a reward for processing an exit. The cost of processing multiple exits from the exit queue at once is less than the cost of processing them individually. For simplicity and to save gas however, the **Process Exit Bounty** amount associated with each exit is given out to the **Exit Processor**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For simplicity and to save gas however,
I am a bit lost on what this part is aiming to explain actually 😅 where it is simplifying and saving gas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think it will be better to point out the stacking exits by the exit processor
for more incentives part here instead, since saving gas is on their(the exit processors) side. cc @thec00n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated ddcb22f
Co-authored-by: boolafish <boolafish945@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one minor wording change
Co-authored-by: Kevin Sullivan <4653170+kevsul@users.noreply.github.com>
No description provided.