Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document PE Bounty and Bond Design #702

Merged
merged 19 commits into from
Oct 23, 2020
Merged

Document PE Bounty and Bond Design #702

merged 19 commits into from
Oct 23, 2020

Conversation

souradeep-das
Copy link
Contributor

No description provided.

@souradeep-das souradeep-das marked this pull request as draft September 1, 2020 06:16
@souradeep-das
Copy link
Contributor Author

There could have been another approach, where without combining the values in struct, we try to compare and return the max value between the bond and bounty, but I think this is cleaner?

Copy link
Contributor

@kevsul kevsul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, I've added some definitions and edited for clarity in some places

souradeep-das and others added 2 commits September 30, 2020 12:01
Co-authored-by: Kevin Sullivan <4653170+kevsul@users.noreply.github.com>
Co-authored-by: thec00n <thec00n@fork.at>
@souradeep-das souradeep-das marked this pull request as ready for review October 16, 2020 10:57
**_On succesfull challenge:_**
*Bond -> from `Exit Game Contract` to `Challenger`*

The **Exit Processor** gets the bounty as a reward for processing an exit. The cost of processing multiple exits from the exit queue at once is less than the cost of processing them individually. For simplicity and to save gas however, the **Process Exit Bounty** amount associated with each exit is given out to the **Exit Processor**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity and to save gas however,

I am a bit lost on what this part is aiming to explain actually 😅 where it is simplifying and saving gas?

Copy link
Contributor Author

@souradeep-das souradeep-das Oct 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it will be better to point out the stacking exits by the exit processor for more incentives part here instead, since saving gas is on their(the exit processors) side. cc @thec00n

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated ddcb22f

Copy link
Contributor

@kevsul kevsul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor wording change

@souradeep-das souradeep-das merged commit e2e3244 into v2.0.0 Oct 23, 2020
@souradeep-das souradeep-das deleted the docs branch October 23, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants