feat: emit an event indicating that in-flight exit has finalized #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InoMurko
reviewed
Jun 22, 2020
| @@ -123,6 +127,8 @@ library PaymentProcessInFlightExit { | |||
| if (!success) { | |||
| emit InFlightBondReturnFailed(exit.bondOwner, exit.bondSize); | |||
| } | |||
|
|
|||
| emit InFlightExitFinalized(exitId); | |||
There was a problem hiding this comment.
whoa! how was this one missed. cool we finally cought it
There was a problem hiding this comment.
Can we swap L141 and L142 🙈 if we add another commit
pgebal
force-pushed
the
pgebal/emit_ife_finalized_to_v2.0.0
branch
from
ed74974
to
8833d03
Compare
pgebal
force-pushed
the
pgebal/emit_ife_finalized_to_v2.0.0
branch
from
8833d03
to
9e88dd9
Compare
|
@kevsul @souradeep-das should we do this too? |
souradeep-das
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Let's also generate solidoc before merge if we can?
and
#647 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #646