Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ife stop eating wrong side bond #585

Merged
merged 9 commits into from
Feb 19, 2020
Merged

ife stop eating wrong side bond #585

merged 9 commits into from
Feb 19, 2020

Commits on Feb 17, 2020

  1. fix: return piggyback bond when piggyback wrong side 

    This commit change the behavior to be returning piggyback bond no matter it is on the right side of canoncity or not.

issue: #584
    @boolafish
    boolafish committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    b053443 View commit details
    Browse the repository at this point in the history

  2. test: add unit test covering fix of IFE piggyback bond

    @boolafish
    boolafish committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    23045a1 View commit details
    Browse the repository at this point in the history

  3. fix: e2e tests (py + truffle) for IFE bond change

    @boolafish
    boolafish committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    5dbe305 View commit details
    Browse the repository at this point in the history

  4. docs: add explanation on why not need to filter challenged in/output

    @boolafish
    boolafish committed Feb 17, 2020
    Configuration menu
    Copy the full SHA
    15dffd9 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2020

  1. docs: better comment sentence 

    by PR review suggestion

Co-Authored-By: Kevin Sullivan <4653170+kevsul@users.noreply.github.com>
    @boolafish @kevsul
    boolafish and kevsul committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    58c957e View commit details
    Browse the repository at this point in the history

  2. feat: add changelog instruction to bumping version 

    Also format the README file a bit.
    @boolafish
    boolafish committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    b0fcf65 View commit details
    Browse the repository at this point in the history

  3. chore: bumping version to 1.0.3 

    - run `npm version patch -m`
- update changelog
    @boolafish
    boolafish committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    bbcec61 View commit details
    Browse the repository at this point in the history

  4. fix: update CHANGELOG.md wording 

    for PR review

Co-Authored-By: Kevin Sullivan <4653170+kevsul@users.noreply.github.com>
    @boolafish @kevsul
    boolafish and kevsul committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    d9bc0a1 View commit details
    Browse the repository at this point in the history

  5. refactor: for loop with in/outputs length instead of MAX_IN/OUTPUT_SIZE 

    Although the inputs and outputs storage is defined to be exactly the max size of payment tx inputs/outputs. However, using the length itself makes the code more
self explaining.
    @boolafish
    boolafish committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    5758669 View commit details
    Browse the repository at this point in the history