test: payment v2 with standard exit #1589

boolafish · 2020-06-18T09:02:35Z

📋 https://github.com/omgnetwork/new-tx-type-poc/issues/5

Overview

test to ensure payment v2 exit event is handled

Changes

Add cabbage test. Currently is has shown that child chain and watcher-info somehow can handle 2 payment exit events.

warning, watcher is not tested!

Currently, child chain works and watcher can recognize the event and then pass it to watcher info. Since payment v1 and v2 has the same tx and output format, so it works to push the data to DB with different type info.

Testing

CI

* feat: start multiple exit processors * chore: use snapshot support payment v2 ... and run mix format * fix: setup exit_games for test fixture * fix: dispatch return in the format of {:ok, []} * fix: make watcher integ test to work * fix: unit test for EthEventAggregator 1. fix the unit tests, add address to log result 2. change how we bind contract address to log, use the pre-decoded address data * fix: patch payment_exit_game back into contract_addr * fix: wrong filter_events mapping * fix: linter, dializer, remove tmp logging * fix: use snapwhot with payment v2 Previous snapshot was wrong. Using this one: omisego-images/docker-elixir-omg#43 (comment) * refactor: restrain from using ++ Use [a|b] as best practice * chore: use Task.async_stream instad of sync looping * refactor: move private functions to the end * fix: map after Task.async_stream Co-authored-by: Thibault Denizet <thibault@omisego.co>

Tested by hacking the watcher info /transaction.create to generate payment v2 tx instead. And then the tx would be signed and send normally. Tested with the cabbage transaction tests. This commit instead of providing new module for payment, it reuses most of the part instead of the function that generate the payment struct. This commit introduces Payment.Builder to build different payment tx. Probably not the most clean way of handling things but the least change required to allow cabbage test to work.

add tx_type as a param of 'order'. If not passed, default to 1 for backward competibility.

linter, dialyzer, remove branching on tx type when building payment tx.

Simplify the test code and make it easier to read

…gnize_v2_exit

pnowosie

Nice 🎉

pnowosie · 2020-06-25T07:57:34Z

priv/cabbage/apps/itest/test/itest/payment_v2_test.exs

@@ -50,7 +51,10 @@ defmodule PaymentV2Test do
    balance = Client.get_exact_balance(alice.account, expecting_amount)
    balance = balance["amount"]

-    assert_equal(expecting_amount, balance, "For #{alice.account}")
+    case expecting_amount do
+      0 -> assert(balance == nil, "Alice ETH amount is not 0")


balance == nil is not obvious and misleading.
Can we set it to zero, kind of (line above): balance = Map.get(balance, "amount", 0)

lol, TIL in elixir you can try to access a value from nil and would return nil instead of crashing.
the Client.get_exact_balance would actually return nil instead of empty map.

I will change to code to the following instead:

Client.get_exact_balance(bob.account, expecting_amount)["amount"] || 0

pnowosie · 2020-06-25T07:58:56Z

priv/cabbage/apps/itest/test/itest/payment_v2_test.exs

    balance = Client.get_exact_balance(bob.account, expecting_amount)["amount"]

-    assert_equal(expecting_amount, balance, "For Bob: #{bob.account}")
+    case expecting_amount do


pnowosie · 2020-06-25T08:00:20Z

priv/cabbage/apps/itest/test/itest/payment_v2_test.exs

    {:ok, state}
  end

+  defthen ~r/^Alice should have "(?<amount>[^"]+)" ETH on the child chain after finality margin$/,


Can we parametrize Alice - looks like it will work for any entity. Thank you 👍

ok, add the step Given Alice has an ethereum account that generates the user account and put it into state instead!

* feat: multiple exit processors (#1573) * feat: start multiple exit processors * chore: use snapshot support payment v2 ... and run mix format * fix: setup exit_games for test fixture * fix: dispatch return in the format of {:ok, []} * fix: make watcher integ test to work * fix: unit test for EthEventAggregator 1. fix the unit tests, add address to log result 2. change how we bind contract address to log, use the pre-decoded address data * fix: patch payment_exit_game back into contract_addr * fix: wrong filter_events mapping * fix: linter, dializer, remove tmp logging * fix: use snapwhot with payment v2 Previous snapshot was wrong. Using this one: omisego-images/docker-elixir-omg#43 (comment) * refactor: restrain from using ++ Use [a|b] as best practice * chore: use Task.async_stream instad of sync looping * refactor: move private functions to the end * fix: map after Task.async_stream Co-authored-by: Thibault Denizet <thibault@omisego.co> * feat: test with payment v2 transfer Tested by hacking the watcher info /transaction.create to generate payment v2 tx instead. And then the tx would be signed and send normally. Tested with the cabbage transaction tests. This commit instead of providing new module for payment, it reuses most of the part instead of the function that generate the payment struct. This commit introduces Payment.Builder to build different payment tx. Probably not the most clean way of handling things but the least change required to allow cabbage test to work. * feat: allow /transaction.create to pass in tx_type add tx_type as a param of 'order'. If not passed, default to 1 for backward competibility. * test: cabbage test for payment v2 transfer * fix: cleanup linter, dialyzer, remove branching on tx type when building payment tx. * refactor: use Alice and Bob instead Simplify the test code and make it easier to read * fix: credo complain single pipe * test: payment v2 with standard exit * fix: compiler warning me :( * refactor: remove commented codes * fix: linter * style: simpler code * refactor: parameterize users Co-authored-by: Thibault Denizet <thibault@omisego.co>

boolafish and others added 9 commits June 18, 2020 14:36

feat: allow /transaction.create to pass in tx_type

258b1b0

add tx_type as a param of 'order'. If not passed, default to 1 for backward competibility.

test: cabbage test for payment v2 transfer

f7ac25c

fix: cleanup

df74571

linter, dialyzer, remove branching on tx type when building payment tx.

refactor: use Alice and Bob instead

4e8d539

Simplify the test code and make it easier to read

fix: credo complain single pipe

e7db8b8

test: payment v2 with standard exit

4518f26

fix: compiler warning me :(

c7aeca6

Base automatically changed from boolafish/cabbage_payment_v2 to payment_v2_poc June 19, 2020 10:53

boolafish force-pushed the payment_v2_poc branch from e109999 to f3658e2 Compare June 22, 2020 02:30

boolafish added 3 commits June 22, 2020 11:31

Merge branch 'payment_v2_poc' into boolafish/cabbage_child_chain_reco…

dfb9e2c

…gnize_v2_exit

refactor: remove commented codes

9ec5848

fix: linter

abacc16

boolafish marked this pull request as ready for review June 22, 2020 04:56

boolafish requested review from pnowosie and T-Dnzt June 22, 2020 04:57

pnowosie approved these changes Jun 25, 2020

View reviewed changes

boolafish added 2 commits June 30, 2020 15:04

style: simpler code

302078a

refactor: parameterize users

2f23e4c

boolafish merged commit 69d9787 into payment_v2_poc Jun 30, 2020

boolafish deleted the boolafish/cabbage_child_chain_recognize_v2_exit branch June 30, 2020 07:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: payment v2 with standard exit #1589

test: payment v2 with standard exit #1589

boolafish commented Jun 18, 2020 •

edited

Loading

pnowosie left a comment

pnowosie Jun 25, 2020

boolafish Jun 30, 2020 •

edited

Loading

pnowosie Jun 25, 2020

pnowosie Jun 25, 2020

boolafish Jun 30, 2020

test: payment v2 with standard exit #1589

test: payment v2 with standard exit #1589

Conversation

boolafish commented Jun 18, 2020 • edited Loading

Overview

Changes

Testing

pnowosie left a comment

Choose a reason for hiding this comment

pnowosie Jun 25, 2020

Choose a reason for hiding this comment

boolafish Jun 30, 2020 • edited Loading

Choose a reason for hiding this comment

pnowosie Jun 25, 2020

Choose a reason for hiding this comment

pnowosie Jun 25, 2020

Choose a reason for hiding this comment

boolafish Jun 30, 2020

Choose a reason for hiding this comment

boolafish commented Jun 18, 2020 •

edited

Loading

boolafish Jun 30, 2020 •

edited

Loading