Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add send_request after cmd 21 (src:00 dst:c8) #103

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add send_request after cmd 21 (src:00 dst:c8) #103

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52120cf
- add match command 21 and send data; for AC090HCADNH
dansck Feb 22, 2024
87d28bc
Merge branch 'lanwin:main' into AC090HCADNH
dansck Feb 24, 2024
4bcdbd1
add CMD F8 to match also dst "d0" and reset previous changes
dansck Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/samsung_ac/protocol_non_nasa.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ namespace esphome
else if (nonpacket_.cmd == NonNasaCommand::CmdF8)
{
// After cmd F8 (src:c8 dst:f0) is a lage gap in communication, time to send data. Some systems did not sent that.
if (nonpacket_.src == "c8" && nonpacket_.dst == "f0")
if (nonpacket_.src == "c8" && ( nonpacket_.dst == "f0" || nonpacket_.dst == "d0"))
{
// the communication needs a delay from cmdf8 to send the data.
// series of test-delay-times: 1ms: no reaction, 7ms reactions half the time, 10ms very often a reaction (95%) -> delay on 20ms should be safe
Expand Down