Skip to content

Commit

Permalink
Improve aria labeling for input groups on advanced search. #2218
Browse files Browse the repository at this point in the history
  • Loading branch information
kimisgold committed Aug 20, 2024
1 parent 6ef05c3 commit 721a575
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ if ($this->status()->isSiteRequest()) {
}

?>
<div id="resource-class" class="field removable multi-value" role="group">
<div id="resource-class" class="field removable multi-value" role="group" aria-labelledby="by-resource-class-label">
<div class="field-meta">
<span id="by-resource-class-label" class="label"><?php echo $translate('Search by class'); ?></span>
<?php echo $this->hyperlink('', '#', ['class' => 'expand', 'title' => $translate('Expand')]); ?>
Expand Down
4 changes: 2 additions & 2 deletions application/view/common/advanced-search/sort.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ $sortOrder->setValueOptions([
]);
$sortOrder->setValue($query['sort_order'] ?? '');
?>
<div class="field" id="sort_field">
<div class="field" id="sort_field" role="group" aria-labelledby="sort-group-label">
<div class="field-meta">
<label><?php echo $this->translate('Sort'); ?></label>
<label id="sort-group-label"><?php echo $this->translate('Sort'); ?></label>
</div>
<div class="inputs">
<?php echo $this->formSelect($sortBy); ?>
Expand Down

0 comments on commit 721a575

Please sign in to comment.