Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to inject HTMLPurifier config/definitions #857

Merged
merged 2 commits into from
Jun 25, 2018

Conversation

luku
Copy link
Contributor

@luku luku commented Jun 12, 2018

As mentioned in forum if one plugin reads/get values or definitions, the object gets finalized so it's impossible to write/set more values to it later. So other plugins must use $configCopy = HTMLPurifier_Config::inherit($currentConfig);
That is also reason why I included the defaults and allowed elements and attributes as filter arguments (no need to get definitions in order to find out what are the current allowed elements)

Feel free to propose different filter name, perhaps shorter: html_purifier_config is sufficient?

@zerocrates zerocrates merged commit 48fb606 into omeka:master Jun 25, 2018
@zerocrates
Copy link
Member

Looks good to me, thanks!

@luku luku deleted the filter-purifier branch June 25, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants